linux-kernel - Re: [PATCH 0/3] can: grcan: Bug fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 28 Apr 2022 14:46:17 +0200
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Andreas Larsson <andreas@...sler.com>
Cc:     linux-can@...r.kernel.org, Wolfgang Grandegger <wg@...ndegger.com>,
        Oliver Hartkopp <socketcan@...tkopp.net>,
        linux-kernel@...r.kernel.org, software@...sler.com
Subject: Re: [PATCH 0/3] can: grcan: Bug fixes

On 28.04.2022 14:22:17, Andreas Larsson wrote:
> On 2022-04-28 08:50, Marc Kleine-Budde wrote:
> > On 27.04.2022 15:43:04, Andreas Larsson wrote:
> > > These patches
> > > * makes sure that DMA memory is allocated properly
> > > * avoids the tx errata workaround needlessly being applied
> > > * fixes a bug where the driver can be left hanging without interrupts enabled
> > > 
> > > Andreas Larsson (2):
> > >    can: grcan: Fix broken system id check for errata workaround needs
> > >    can: grcan: Only use the napi poll budget for rx
> > > 
> > > Daniel Hellstrom (1):
> > >    can: grcan: use ofdev->dev when allocating DMA memory
> > 
> > Thanks for the patches. Can you please add a "Fixes:" tag to each patch.
> >  From the description it seems they should be backported to the stable
> > kernels, correct?
> 
> For patch 1 I can add a Fixes: that points to 53b7670e5735, which is the
> patch after which the patch is needed (even though that commit is not
> bad in itself, but merely exposes a wrongly used device pointer in the
> grcan driver).

The Fixes tag should point to the patch the introduced the problem, not
the patch the exposes the problem :)

| 53b7670e5735 sparc: factor the dma coherent mapping into helper

> For patch 2 though I am not sure. I don't think the problem has always
> been there, but I am not really sure what commit to point to.

Point the Fixes tag to the commit that introduced the problem, if it was
always there, use the commit where the patch was added.

> The fix is at least needed for 4.9 and onward and 4.9 is the oldest
> stable branch still under maintenance. Seems not to be worth the
> effort to find exactly from which commit the grcan driver's quirky use
> of the napi budget actually lead to problems just to make sure that it
> gets applied to all currently maintained stable branches. Suggestions?

See above.

> For patch 3 I can point to the driver's original commit for the grcan
> driver as the problem has been there all along.

Fine.

regards
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)