linux-kernel - [mark:stackleak/rework 9/13] drivers/misc/lkdtm/stackleak.c:42:23: error: implicit declaration of function 'stackleak_find_top_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202204280834.PTB3Ku7I-lkp@intel.com>
Date:   Thu, 28 Apr 2022 10:00:34 +0800
From:   kernel test robot <lkp@...el.com>
To:     Mark Rutland <mark.rutland@....com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [mark:stackleak/rework 9/13] drivers/misc/lkdtm/stackleak.c:42:23:
 error: implicit declaration of function 'stackleak_find_top_of_poison'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git stackleak/rework
head:   26f638ab0d7c718b10526dae2bd3ea2e3d0286c8
commit: 9aa3a1d3e1f91e96131631d60869eaef8bb8cca5 [9/13] lkdtm/stackleak: rework boundary management
config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20220428/202204280834.PTB3Ku7I-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git/commit/?id=9aa3a1d3e1f91e96131631d60869eaef8bb8cca5
        git remote add mark https://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git
        git fetch --no-tags mark stackleak/rework
        git checkout 9aa3a1d3e1f91e96131631d60869eaef8bb8cca5
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/misc/lkdtm/stackleak.c: In function 'lkdtm_STACKLEAK_ERASING':
   drivers/misc/lkdtm/stackleak.c:17:46: error: implicit declaration of function 'stackleak_task_low_bound' [-Werror=implicit-function-declaration]
      17 |         const unsigned long task_stack_low = stackleak_task_low_bound(current);
         |                                              ^~~~~~~~~~~~~~~~~~~~~~~~
   drivers/misc/lkdtm/stackleak.c:18:47: error: implicit declaration of function 'stackleak_task_high_bound'; did you mean 'stackleak_task_init'? [-Werror=implicit-function-declaration]
      18 |         const unsigned long task_stack_high = stackleak_task_high_bound(current);
         |                                               ^~~~~~~~~~~~~~~~~~~~~~~~~
         |                                               stackleak_task_init
   drivers/misc/lkdtm/stackleak.c:19:42: error: 'current_stack_pointer' undeclared (first use in this function); did you mean 'user_stack_pointer'?
      19 |         const unsigned long current_sp = current_stack_pointer;
         |                                          ^~~~~~~~~~~~~~~~~~~~~
         |                                          user_stack_pointer
   drivers/misc/lkdtm/stackleak.c:19:42: note: each undeclared identifier is reported only once for each function it appears in
   drivers/misc/lkdtm/stackleak.c:20:48: error: 'struct task_struct' has no member named 'lowest_stack'
      20 |         const unsigned long lowest_sp = current->lowest_stack;
         |                                                ^~
>> drivers/misc/lkdtm/stackleak.c:42:23: error: implicit declaration of function 'stackleak_find_top_of_poison' [-Werror=implicit-function-declaration]
      42 |         poison_high = stackleak_find_top_of_poison(task_stack_low, untracked_high);
         |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/stackleak_find_top_of_poison +42 drivers/misc/lkdtm/stackleak.c

    13	
    14	void lkdtm_STACKLEAK_ERASING(void)
    15	{
    16		const unsigned long task_stack_base = (unsigned long)task_stack_page(current);
    17		const unsigned long task_stack_low = stackleak_task_low_bound(current);
    18		const unsigned long task_stack_high = stackleak_task_high_bound(current);
    19		const unsigned long current_sp = current_stack_pointer;
    20		const unsigned long lowest_sp = current->lowest_stack;
    21		unsigned long untracked_high;
    22		unsigned long poison_high, poison_low;
    23		bool test_failed = false;
    24	
    25		/*
    26		 * Depending on what has run prior to this test, the lowest recorded
    27		 * stack pointer could be above or below the current stack pointer.
    28		 * Start from the lowest of the two.
    29		 *
    30		 * Poison values are naturally-aligned unsigned longs. As the current
    31		 * stack pointer might not be sufficiently aligned, we must align
    32		 * downwards to find the lowest known stack pointer value. This is the
    33		 * high boundary for a portion of the stack which may have been used
    34		 * without being tracked, and has to be scanned for poison.
    35		 */
    36		untracked_high = min(current_sp, lowest_sp);
    37		untracked_high = ALIGN_DOWN(untracked_high, sizeof(unsigned long));
    38	
    39		/*
    40		 * Find the top of the poison in the same way as the erasing code.
    41		 */
  > 42		poison_high = stackleak_find_top_of_poison(task_stack_low, untracked_high);

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp