linux-kernel - Re: [PATCH 1/3] arm64: dts: rockchip: enable otg/drd operation of usb_host0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ca670161-7133-631e-f4b6-b48c8fde669b@wolfvision.net>
Date:   Thu, 28 Apr 2022 15:24:09 +0200
From:   Michael Riesch <michael.riesch@...fvision.net>
To:     Nicolas Frattaroli <frattaroli.nicolas@...il.com>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Heiko Stuebner <heiko@...ech.de>,
        Liang Chen <cl@...k-chips.com>,
        Peter Geis <pgwipeout@...il.com>,
        Frank Wunderlich <frank-w@...lic-files.de>
Subject: Re: [PATCH 1/3] arm64: dts: rockchip: enable otg/drd operation of
 usb_host0_xhci in rk356x

Hi Nicolas,

On 4/28/22 13:15, Nicolas Frattaroli wrote:
> On Montag, 25. April 2022 15:35:00 CEST Michael Riesch wrote:
>> This USB 3.0 controller is capable of OTG/DRD operation. Enable it in the
>> device tree.
>>
>> Signed-off-by: Michael Riesch <michael.riesch@...fvision.net>
>> ---
>>  arch/arm64/boot/dts/rockchip/rk356x.dtsi | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
>> index 55e6dcb948cc..f611aaf2d238 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi
>> +++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
>> @@ -266,7 +266,7 @@ usb_host0_xhci: usb@...00000 {
>>  			 <&cru ACLK_USB3OTG0>;
>>  		clock-names = "ref_clk", "suspend_clk",
>>  			      "bus_clk";
>> -		dr_mode = "host";
>> +		dr_mode = "otg";
>>  		phy_type = "utmi_wide";
>>  		power-domains = <&power RK3568_PD_PIPE>;
>>  		resets = <&cru SRST_USB3OTG0>;
>>
> 
> Hi Michael,
> 
> according to official specs[1], only the RK3568 is capable of using the
> USB 3.0 controller in OTG mode. For the RK3566, OTG is USB 2.0, if I
> understand this correctly.
> 
> So I think this should be an override in rk3568.dtsi.

Thanks for pointing that out -- will change in v2 (I'll wait a bit,
though, as I hope that patches 2 and 3 will be applied as they are ;-)

Best regards,
Michael

> 
> Regards,
> Nicolas Frattaroli
> 
> [1]: Compare page 17 of the RK3568 datasheet to page 16 of the RK3566
>      datasheet
> 
>