linux-kernel - Re: [PATCHv13 9/9] soc: qcom: geni: Disable MMIO tracing for GENI SE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220428092959.175b48ae@gandalf.local.home>
Date:   Thu, 28 Apr 2022 09:29:59 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Sai Prakash Ranjan <quic_saipraka@...cinc.com>
Cc:     <arnd@...db.de>, <catalin.marinas@....com>,
        <gregkh@...uxfoundation.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <maz@...nel.org>, <quic_psodagud@...cinc.com>,
        <quic_tsoni@...cinc.com>, <will@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>
Subject: Re: [PATCHv13 9/9] soc: qcom: geni: Disable MMIO tracing for GENI
 SE

On Thu, 28 Apr 2022 18:14:12 +0530
Sai Prakash Ranjan <quic_saipraka@...cinc.com> wrote:

> Disable MMIO tracing for geni serial engine driver as it is a
> high frequency operation with many register reads/writes and
> not very useful to log all MMIO traces and prevent excessive
> logging.

This states what it does but does not really state why. Are you using MMIO
tracing in other locations and this is causing too much noise?

What is the real issue. Just saying "excessive logging" is not sufficient.
That would be a reason to disable function tracing ;-)

-- Steve


> 
> Cc: Bjorn Andersson <bjorn.andersson@...aro.org>
> Signed-off-by: Sai Prakash Ranjan <quic_saipraka@...cinc.com>
> ---
>  drivers/soc/qcom/qcom-geni-se.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c
> index 28a8c0dda66c..a0ceeede450f 100644
> --- a/drivers/soc/qcom/qcom-geni-se.c
> +++ b/drivers/soc/qcom/qcom-geni-se.c
> @@ -1,6 +1,9 @@
>  // SPDX-License-Identifier: GPL-2.0
>  // Copyright (c) 2017-2018, The Linux Foundation. All rights reserved.
>  
> +/* Disable MMIO tracing to prevent excessive logging of unwanted MMIO traces */
> +#define __DISABLE_TRACE_MMIO__
> +
>  #include <linux/acpi.h>
>  #include <linux/clk.h>
>  #include <linux/slab.h>