linux-kernel - Re: [RFC PATCH v4 11/11] fbdev: Make registered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Ymv98Y85rW/2r9m8@infradead.org>
Date:   Fri, 29 Apr 2022 08:02:09 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Javier Martinez Canillas <javierm@...hat.com>
Cc:     linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        kernel test robot <lkp@...el.com>,
        Jens Frederich <jfrederich@...il.com>,
        Jon Nettleton <jon.nettleton@...il.com>,
        linux-staging@...ts.linux.dev,
        Daniel Vetter <daniel.vetter@...el.com>,
        Daniel Vetter <daniel@...ll.ch>, Helge Deller <deller@....de>,
        Matthew Wilcox <willy@...radead.org>,
        Sam Ravnborg <sam@...nborg.org>,
        Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>,
        Zhen Lei <thunder.leizhen@...wei.com>,
        Alex Deucher <alexander.deucher@....com>,
        Xiyu Yang <xiyuyang19@...an.edu.cn>,
        linux-fbdev@...r.kernel.org, Zheyu Ma <zheyuma97@...il.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Changcheng Deng <deng.changcheng@....com.cn>
Subject: Re: [RFC PATCH v4 11/11] fbdev: Make registered_fb[] private to
 fbmem.c

On Fri, Apr 29, 2022 at 10:42:53AM +0200, Javier Martinez Canillas wrote:
> From: Daniel Vetter <daniel.vetter@...ll.ch>
> 
> Well except when the olpc dcon fbdev driver is enabled, that thing
> digs around in there in rather unfixable ways.
> 
> Cc oldc_dcon maintainers as fyi.
> 
> v2: I typoed the config name (0day)

We should not keep broken code and/or core code ifdefs around for
staging drivers.  Just disable the driver if it is in such a bad
state.