linux-kernel - Re: [PATCH] arch/mips/kernel/traps: add CONFIG_MIPS_FP_SUPPORT when using handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANubcdXSHpV8xOBidXksMt+kLQ=jgNer4uisKbV5z9zxHp8dMw@mail.gmail.com>
Date:   Fri, 29 Apr 2022 11:10:25 +0800
From:   Stephen Zhang <starzhangzsd@...il.com>
To:     "Maciej W. Rozycki" <macro@...am.me.uk>
Cc:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Joshua Kinard <kumba@...too.org>, liam.howlett@...cle.com,
        ebiederm@...ssion.com, dbueso@...e.de, alobakin@...me,
        f.fainelli@...il.com, zhangshida <zhangshida@...inos.cn>,
        linux-kernel@...r.kernel.org, linux-mips@...r.kernel.org
Subject: Re: [PATCH] arch/mips/kernel/traps: add CONFIG_MIPS_FP_SUPPORT when
 using handle_fpe

Maciej W. Rozycki <macro@...am.me.uk> 于2022年4月28日周四 17:00写道：
>
> On Thu, 28 Apr 2022, Stephen Zhang wrote:
>  Thanks.
>
>  The bug is in arch/mips/include/asm/mach-ip27/cpu-feature-overrides.h,
> which has:
>
> #define cpu_has_fpu                     1
>
> (and similarly arch/mips/include/asm/mach-ip30/cpu-feature-overrides.h).
> This is not supported, as noted in arch/mips/include/asm/cpu-features.h:
>
> /* Don't override `cpu_has_fpu' to 1 or the "nofpu" option won't work.  */
>
> Perhaps we should explicitly undefine `cpu_has_fpu' if set to 1?
>
>   Maciej

Thanks for your detailed explanation and suggestion. I will make a v2 patch.