linux-kernel - Re: [PATCH 1/3] KVM: x86: make vendor code check for all nested events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0b554e22-6766-8299-287c-c40240c08536@redhat.com>
Date:   Fri, 29 Apr 2022 19:09:06 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Sean Christopherson <seanjc@...gle.com>
Cc:     linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        mlevitsk@...hat.com, stable@...r.kernel.org
Subject: Re: [PATCH 1/3] KVM: x86: make vendor code check for all nested
 events

On 4/29/22 19:03, Sean Christopherson wrote:
> This doesn't even compile...
> 
> arch/x86/kvm/vmx/nested.c: In function ‘vmx_has_nested_events’:
> arch/x86/kvm/vmx/nested.c:3862:61: error: ‘vmx’ undeclared (first use in this function)
>   3862 |         return nested_vmx_preemption_timer_pending(vcpu) || vmx->nested.mtf_pending;
>        |                                                             ^~~
> arch/x86/kvm/vmx/nested.c:3862:61: note: each undeclared identifier is reported only once for each function it appears in
>    CC [M]  arch/x86/kvm/svm/svm_onhyperv.o
> arch/x86/kvm/vmx/nested.c:3863:1: error: control reaches end of non-void function [-Werror=return-type]
>   3863 | }
>        | ^
> cc1: all warnings being treated as errors
>    LD [M]  arch/x86/kvm/kvm.o

Yeah, it doesn't.  Of course this will need a v2, also because there are 
failures in the vmx tests.

What can I say, testing these patches on AMD hardware wasn't a great idea.

Paolo