linux-kernel - Re: [PATCH] arm64: Declare non global symbols as static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Ymw3JY5m1R0W8/l5@arm.com>
Date:   Fri, 29 Apr 2022 20:06:13 +0100
From:   Catalin Marinas <catalin.marinas@....com>
To:     Linu Cherian <lcherian@...vell.com>
Cc:     maz@...nel.org, will@...nel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linuc.decode@...il.com,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] arm64: Declare non global symbols as static

On Fri, Apr 29, 2022 at 01:25:35PM +0530, Linu Cherian wrote:
> Fix below sparse warnings introduced while adding errata.
> 
> arch/arm64/kernel/cpu_errata.c:218:25: sparse: warning: symbol
> 'cavium_erratum_23154_cpus' was not declared. Should it be static?
> arch/arm64/kernel/cpu_errata.c:233:25: sparse: warning: symbol
> 'cavium_erratum_27456_cpus' was not declared. Should it be static?
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Linu Cherian <lcherian@...vell.com>
> ---
>  arch/arm64/kernel/cpu_errata.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/kernel/cpu_errata.c b/arch/arm64/kernel/cpu_errata.c
> index 4c9b5b4b7a0b..57a39cb6b489 100644
> --- a/arch/arm64/kernel/cpu_errata.c
> +++ b/arch/arm64/kernel/cpu_errata.c
> @@ -215,7 +215,7 @@ static const struct arm64_cpu_capabilities arm64_repeat_tlbi_list[] = {
>  #endif
>  
>  #ifdef CONFIG_CAVIUM_ERRATUM_23154
> -const struct midr_range cavium_erratum_23154_cpus[] = {
> +static const struct midr_range cavium_erratum_23154_cpus[] = {
>  	MIDR_ALL_VERSIONS(MIDR_THUNDERX),
>  	MIDR_ALL_VERSIONS(MIDR_THUNDERX_81XX),
>  	MIDR_ALL_VERSIONS(MIDR_THUNDERX_83XX),
> @@ -230,7 +230,7 @@ const struct midr_range cavium_erratum_23154_cpus[] = {
>  #endif
>  
>  #ifdef CONFIG_CAVIUM_ERRATUM_27456
> -const struct midr_range cavium_erratum_27456_cpus[] = {
> +static const struct midr_range cavium_erratum_27456_cpus[] = {
>  	/* Cavium ThunderX, T88 pass 1.x - 2.1 */
>  	MIDR_RANGE(MIDR_THUNDERX, 0, 0, 1, 1),
>  	/* Cavium ThunderX, T81 pass 1.0 */

That's referred in arch/arm64/kernel/cpufeature.c, so the build fails.

-- 
Catalin