linux-kernel - Re: [PATCH 22/41] ARM: omap1: move plat/dma.c to mach/omap-dma.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7e47c5fa-4cff-b12f-20ce-2e62b62ec538@gmail.com>
Date:   Fri, 29 Apr 2022 22:36:53 +0300
From:   Péter Ujfalusi <peter.ujfalusi@...il.com>
To:     Arnd Bergmann <arnd@...nel.org>, linux-omap@...r.kernel.org,
        tony@...mide.com, aaro.koskinen@....fi, jmkrzyszt@...il.com
Cc:     Arnd Bergmann <arnd@...db.de>,
        Russell King <linux@...linux.org.uk>,
        Paul Walmsley <paul@...an.com>,
        Kevin Hilman <khilman@...nel.org>,
        Vinod Koul <vkoul@...nel.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Dominik Brodowski <linux@...inikbrodowski.net>,
        Mark Brown <broonie@...nel.org>,
        Felipe Balbi <balbi@...nel.org>,
        Alan Stern <stern@...land.harvard.edu>,
        Lee Jones <lee.jones@...aro.org>,
        Daniel Thompson <daniel.thompson@...aro.org>,
        Jingoo Han <jingoohan1@...il.com>,
        Helge Deller <deller@....de>,
        Linus Walleij <linus.walleij@...aro.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org, dmaengine@...r.kernel.org,
        linux-input@...r.kernel.org, linux-mmc@...r.kernel.org,
        linux-serial@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linux-fbdev@...r.kernel.org, alsa-devel@...a-project.org
Subject: Re: [PATCH 22/41] ARM: omap1: move plat/dma.c to mach/omap-dma.c



On 4/19/22 16:37, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Most of the interface functions in plat/dma.c are only used from the
> USB driver, which is practically OMAP1 specific, except for compile
> testing.
> 
> The omap_get_plat_info(), omap_request_dma() and omap_free_dma()
> functions are never called on omap2 because of runtime checks.

Reviewed-by: Peter Ujfalusi <peter.ujfalusi@...il.com>

> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  arch/arm/mach-omap1/Makefile                        | 2 +-
>  arch/arm/{plat-omap/dma.c => mach-omap1/omap-dma.c} | 0
>  arch/arm/plat-omap/Makefile                         | 2 +-
>  3 files changed, 2 insertions(+), 2 deletions(-)
>  rename arch/arm/{plat-omap/dma.c => mach-omap1/omap-dma.c} (100%)
> 
> diff --git a/arch/arm/mach-omap1/Makefile b/arch/arm/mach-omap1/Makefile
> index 450bbf552b57..0615cb0ba580 100644
> --- a/arch/arm/mach-omap1/Makefile
> +++ b/arch/arm/mach-omap1/Makefile
> @@ -5,7 +5,7 @@
>  
>  # Common support
>  obj-y := io.o id.o sram-init.o sram.o time.o irq.o mux.o flash.o \
> -	 serial.o devices.o dma.o fb.o
> +	 serial.o devices.o dma.o omap-dma.o fb.o
>  obj-y += clock.o clock_data.o opp_data.o reset.o pm_bus.o timer.o
>  
>  ifneq ($(CONFIG_SND_SOC_OMAP_MCBSP),)
> diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/mach-omap1/omap-dma.c
> similarity index 100%
> rename from arch/arm/plat-omap/dma.c
> rename to arch/arm/mach-omap1/omap-dma.c
> diff --git a/arch/arm/plat-omap/Makefile b/arch/arm/plat-omap/Makefile
> index 68ccec9de106..5d55295a14ee 100644
> --- a/arch/arm/plat-omap/Makefile
> +++ b/arch/arm/plat-omap/Makefile
> @@ -6,4 +6,4 @@
>  ccflags-$(CONFIG_ARCH_MULTIPLATFORM) := -I$(srctree)/arch/arm/plat-omap/include
>  
>  # Common support
> -obj-y := sram.o dma.o
> +obj-y := sram.o

-- 
Péter