linux-kernel - Re: [v4 16/18] dt-bindings: mediatek: mt8186: add mt8186-mt6366-da7219-max98357 document

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 29 Apr 2022 15:16:33 -0500
From:   Rob Herring <robh@...nel.org>
To:     Jiaxin Yu <jiaxin.yu@...iatek.com>
Cc:     broonie@...nel.org, angelogioacchino.delregno@...labora.com,
        devicetree@...r.kernel.org, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org,
        Project_Global_Chrome_Upstream_Group@...iatek.com,
        tzungbi@...gle.com, linux-mediatek@...ts.infradead.org,
        trevor.wu@...iatek.com, matthias.bgg@...il.com, aaronyu@...gle.com,
        julianbraha@...il.com, linux-arm-kernel@...ts.infradead.org
Subject: Re: [v4 16/18] dt-bindings: mediatek: mt8186: add
 mt8186-mt6366-da7219-max98357 document

On Fri, Apr 29, 2022 at 05:40:02PM +0800, Jiaxin Yu wrote:
> On Thu, 2022-04-28 at 09:31 -0500, Rob Herring wrote:
> > On Thu, Apr 28, 2022 at 05:33:53PM +0800, Jiaxin Yu wrote:
> > > Add document for mt8186 board with mt6366, da7219 and max98357.
> > > 
> > > Signed-off-by: Jiaxin Yu <jiaxin.yu@...iatek.com>
> > > ---
> > >  .../sound/mt8186-mt6366-da7219-max98357.yaml  | 71
> > > +++++++++++++++++++
> > >  1 file changed, 71 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/sound/mt8186-
> > > mt6366-da7219-max98357.yaml
> > > 
> > > diff --git a/Documentation/devicetree/bindings/sound/mt8186-mt6366-
> > > da7219-max98357.yaml
> > > b/Documentation/devicetree/bindings/sound/mt8186-mt6366-da7219-
> > > max98357.yaml
> > > new file mode 100644
> > > index 000000000000..55e8649f2aea
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/sound/mt8186-mt6366-da7219-
> > > max98357.yaml
> > > @@ -0,0 +1,71 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: 
> > > http://devicetree.org/schemas/sound/mt8186-mt6366-da7219-max98357.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Mediatek MT8186 with MT6366, DA7219 and MAX98357 ASoC sound
> > > card driver
> > > +
> > > +maintainers:
> > > +  - Jiaxin Yu <jiaxin.yu@...iatek.com>
> > > +
> > > +description:
> > > +  This binding describes the MT8186 sound card.
> > > +
> > > +properties:
> > > +  compatible:
> > > +    enum:
> > > +      - mediatek,mt8186_mt6366_da7219_max98357_sound
> > 
> > s/_/-/
> > 
> Got it.
> > > +
> > > +  mediatek,platform:
> > > +    $ref: "/schemas/types.yaml#/definitions/phandle"
> > > +    description: The phandle of MT8186 ASoC platform.
> > > +
> > > +  headset-codec:
> > > +    type: object
> > 
> >        additionalProperties: false
> Ditto.
> > 
> > > +    properties:
> > > +      sound-dai:
> > > +        $ref: /schemas/types.yaml#/definitions/phandle
> > 
> > sound-dai already has a type, so drop and define how many entries.
> > 
> Ditto.

No need to reply in agreement. Just trim the email instead.

> > > +    properties:
> > > +      sound-dai:
> > > +        minItems: 2
> > > +        maxItems: 3
> > 
> > If more than 1 entry, then you need to define what each one is and
> > the 
> > order. Just like reg, interrupts, clocks, etc.
> > 
> Hi Rob,
> 
> Should I correct them as below?
> 
> ---
> properties:
>   sound-dai:
>     minItems: 2
>     maxItems: 3
>     items:
>       - items:
>           - description: xxx
>           - description: yyy
>           - description: zzz

Drop the outer 'items'. As-is, you are saying you have 1 entry with 3 
cells (1 phandle + 2 arg cells).

Rob