linux-kernel - Re: [PATCH v2] media: s5c73m3: replace legacy gpio interface for gpiod

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202204291212.g99NfHX0-lkp@intel.com>
Date:   Fri, 29 Apr 2022 12:48:40 +0800
From:   kernel test robot <lkp@...el.com>
To:     Maíra Canal <maira.canal@....br>,
        s.nawrocki@...sung.com, andrzej.hajda@...el.com, mchehab@...nel.org
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] media: s5c73m3: replace legacy gpio interface for
 gpiod

Hi "Maíra,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on media-tree/master]
[also build test ERROR on v5.18-rc4 next-20220428]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Ma-ra-Canal/media-s5c73m3-replace-legacy-gpio-interface-for-gpiod/20220429-081656
base:   git://linuxtv.org/media_tree.git master
config: arm64-randconfig-r022-20220428 (https://download.01.org/0day-ci/archive/20220429/202204291212.g99NfHX0-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project c59473aacce38cd7dd77eebceaf3c98c5707ab3b)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # https://github.com/intel-lab-lkp/linux/commit/427ae1b9cae644d199f9ffc260480dd1c32ec9d6
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Ma-ra-Canal/media-s5c73m3-replace-legacy-gpio-interface-for-gpiod/20220429-081656
        git checkout 427ae1b9cae644d199f9ffc260480dd1c32ec9d6
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/media/i2c/s5c73m3/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/media/i2c/s5c73m3/s5c73m3-core.c:1359:32: error: too few arguments to function call, expected 2, have 1
           int val = gpiod_set_value(gpio);
                     ~~~~~~~~~~~~~~~     ^
   include/linux/gpio/consumer.h:119:6: note: 'gpiod_set_value' declared here
   void gpiod_set_value(struct gpio_desc *desc, int value);
        ^
   drivers/media/i2c/s5c73m3/s5c73m3-core.c:1366:32: error: too few arguments to function call, expected 2, have 1
           int val = gpiod_set_value(gpio);
                     ~~~~~~~~~~~~~~~     ^
   include/linux/gpio/consumer.h:119:6: note: 'gpiod_set_value' declared here
   void gpiod_set_value(struct gpio_desc *desc, int value);
        ^
   2 errors generated.


vim +1359 drivers/media/i2c/s5c73m3/s5c73m3-core.c

  1356	
  1357	static int s5c73m3_gpio_assert(struct gpio_desc *gpio)
  1358	{
> 1359		int val = gpiod_set_value(gpio);
  1360	
  1361		return s5c73m3_gpio_set_value(gpio, val);
  1362	}
  1363	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp