linux-kernel - [PATCH] Bluetooth: hci_qca: fix excluded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 30 Apr 2022 06:59:54 +0800
From:   kernel test robot <lkp@...el.com>
To:     Balakrishna Godavarthi <quic_bgodavar@...cinc.com>,
        agross@...nel.org, robh+dt@...nel.org, bjorn.andersson@...aro.org,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, marcel@...tmann.org,
        johan.hedberg@...il.com
Cc:     kbuild-all@...ts.01.org, mka@...omium.org,
        linux-bluetooth@...r.kernel.org, quic_hemantg@...cinc.com,
        quic_saluvala@...cinc.com, quic_rjliao@...cinc.com,
        mcchou@...omium.org,
        Balakrishna Godavarthi <quic_bgodavar@...cinc.com>
Subject: [PATCH] Bluetooth: hci_qca: fix excluded_middle.cocci warnings

From: kernel test robot <lkp@...el.com>

drivers/bluetooth/hci_qca.c:1633:42-44: WARNING !A || A && B is equivalent to !A || B


 Condition !A || A && B is equivalent to !A || B.

Generated by: scripts/coccinelle/misc/excluded_middle.cocci

CC: Balakrishna Godavarthi <quic_bgodavar@...cinc.com>
Reported-by: kernel test robot <lkp@...el.com>
Signed-off-by: kernel test robot <lkp@...el.com>
---

url:    https://github.com/intel-lab-lkp/linux/commits/Balakrishna-Godavarthi/WAR-to-handle-WCN6750-hardware-issue/20220429-193129
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
:::::: branch date: 11 hours ago
:::::: commit date: 11 hours ago

 drivers/bluetooth/hci_qca.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/bluetooth/hci_qca.c
+++ b/drivers/bluetooth/hci_qca.c
@@ -1630,7 +1630,7 @@ static int qca_regulator_init(struct hci
 		msleep(50);
 	}
 
-	if (!qcadev->wlan_en || (qcadev->wlan_en && gpiod_get_value_cansleep(qcadev->wlan_en)))
+	if (!qcadev->wlan_en || gpiod_get_value_cansleep(qcadev->wlan_en))
 		gpiod_set_value_cansleep(qcadev->bt_en, 1);
 
 	if (qcadev->wlan_en && !gpiod_get_value_cansleep(qcadev->wlan_en)) {