linux-kernel - Re: [PATCH] UBIFS: simplify the return expression of run_gc()

Open Source and information security mailing list archives

Message-ID: <0de6c8c0-a936-7845-b4ce-51355661e736@microchip.com>
Date:   Fri, 29 Apr 2022 07:02:28 +0000
From:   <Tudor.Ambarus@...rochip.com>
To:     <cgel.zte@...il.com>, <richard@....at>
CC:     <linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        <chi.minghao@....com.cn>, <zealci@....com.cn>
Subject: Re: [PATCH] UBIFS: simplify the return expression of run_gc()

On 4/29/22 08:45, cgel.zte@...il.com wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> From: Minghao Chi <chi.minghao@....com.cn>
> 
> Simplify the return expression.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@....com.cn>
Reviewed-by: Tudor Ambarus <tudor.ambarus@...rochip.com>

> ---
>  fs/ubifs/budget.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/fs/ubifs/budget.c b/fs/ubifs/budget.c
> index c0b84e960b20..e8b9b756f0ac 100644
> --- a/fs/ubifs/budget.c
> +++ b/fs/ubifs/budget.c
> @@ -65,7 +65,7 @@ static void shrink_liability(struct ubifs_info *c, int nr_to_write)
>   */
>  static int run_gc(struct ubifs_info *c)
>  {
> -       int err, lnum;
> +       int lnum;
> 
>         /* Make some free space by garbage-collecting dirty space */
>         down_read(&c->commit_sem);
> @@ -76,10 +76,7 @@ static int run_gc(struct ubifs_info *c)
> 
>         /* GC freed one LEB, return it to lprops */
>         dbg_budg("GC freed LEB %d", lnum);
> -       err = ubifs_return_leb(c, lnum);
> -       if (err)
> -               return err;
> -       return 0;
> +       return ubifs_return_leb(c, lnum);
>  }
> 
>  /**
> --
> 2.25.1
> 
> 
> 
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives