linux-kernel - Re: [PATCH] dt-bindings: arm: mediatek: mmsys: refine power and gce properties

Open Source and information security mailing list archives

Message-ID: <0a43e9787c8e4886b361268a58e755afbf81be1d.camel@mediatek.com>
Date:   Fri, 29 Apr 2022 15:54:41 +0800
From:   Jason-JH Lin <jason-jh.lin@...iatek.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
CC:     Fabien Parent <fparent@...libre.com>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>, CK Hu <ck.hu@...iatek.com>,
        Rex-BC Chen <rex-bc.chen@...iatek.com>,
        Nancy Lin <nancy.lin@...iatek.com>,
        Singo Chang <singo.chang@...iatek.com>,
        <Project_Global_Chrome_Upstream_Group@...iatek.com>
Subject: Re: [PATCH] dt-bindings: arm: mediatek: mmsys: refine power and gce
 properties

Hi Krzysztof,

Thanks for the reviews.

On Fri, 2022-04-29 at 07:55 +0200, Krzysztof Kozlowski wrote:
> On 29/04/2022 06:10, Jason-JH Lin wrote:
> > Yes, we cannot have infinite number for this, but we can use not
> > only
> > one mbox channel for one mmsys.
> > 
> > Its maximum number is equal to GCE HW thread number.
> > The maximum number in mt8195 is 24 and mt8173 is 16.
> > 
> > But we currently using 1.
> > So I'm not sure if I need to set the maxItems for this?
> 
> Yes. 24 for mt8195 and 16 for mt8173.
> 
OK, I'll add maxItems: 24.
> > 
> > > 
> > > >      description:
> > > > -      Using mailbox to communicate with GCE, it should have
> > > > this
> > > > -      property and list of phandle, mailbox specifiers. See
> > > > -      Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> > > > for
> > > > details.
> > > > -    $ref: /schemas/types.yaml#/definitions/phandle-array
> > > > +      If using mailbox to communicate with GCE, it should have
> > > > this
> > > > +      property. GCE will help configure the hardware settings
> > > > for
> > > > the
> > > > +      current mmsys data pipeline.
> > > >  
> > > >    mediatek,gce-client-reg:
> > > > -    description:
> > > > -      The register of client driver can be configured by gce
> > > > with
> > > > 4 arguments
> > > > -      defined in this property, such as phandle of gce, subsys
> > > > id,
> > > > -      register offset and size.
> > > > -      Each subsys id is mapping to a base address of display
> > > > function blocks
> > > > -      register which is defined in the gce header
> > > > -      include/dt-bindings/gce/<chip>-gce.h.
> > > > -    $ref: /schemas/types.yaml#/definitions/phandle-array
> > > 
> > > Why removing ref? Does your binding work after such change?
> > 
> > I removed it unexpectedly, I'll add it back.
> 
> Just be sure you test it before submitting...
> 
I'm sorry about this.
I think something wrong in my local scanning environment.
I'll fix this and test it before submitting the next version.

Regards,
Jason-JH.Lin
> 
> Best regards,
> Krzysztof
> 
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@...ts.infradead.org
> 
https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linux-mediatek__;!!CTRNKA9wMg0ARbw!3EBAk7zcr3iMc-Todq-efcLmYCZNkxH9gYnUmY1tHbPiVm9yNYhrI-Yj0I16f8jGnA6B$
>  
-- 
Jason-JH Lin <jason-jh.lin@...iatek.com>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives