linux-kernel - Re: [PATCH 12/16] zonefs: allow non power of 2 zoned devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5927dc09-89ca-973a-2e24-99be696d4240@samsung.com>
Date:   Fri, 29 Apr 2022 09:55:18 +0200
From:   Pankaj Raghav <p.raghav@...sung.com>
To:     Damien Le Moal <damien.lemoal@...nsource.wdc.com>,
        <jaegeuk@...nel.org>, <axboe@...nel.dk>, <snitzer@...nel.org>,
        <hch@....de>, <mcgrof@...nel.org>, <naohiro.aota@....com>,
        <sagi@...mberg.me>, <dsterba@...e.com>,
        <johannes.thumshirn@....com>
CC:     <linux-kernel@...r.kernel.org>, <clm@...com>,
        <gost.dev@...sung.com>, <chao@...nel.org>, <josef@...icpanda.com>,
        <jonathan.derrick@...ux.dev>, <agk@...hat.com>,
        <kbusch@...nel.org>, <kch@...dia.com>,
        <linux-nvme@...ts.infradead.org>, <bvanassche@....org>,
        <jiangbo.365@...edance.com>, <linux-fsdevel@...r.kernel.org>,
        <matias.bjorling@....com>, <linux-block@...r.kernel.org>
Subject: Re: [PATCH 12/16] zonefs: allow non power of 2 zoned devices

Hi Damien,
On 2022-04-28 23:49, Damien Le Moal wrote:
> This is still not convincing given the code I saw. Additional test cases
> need to be added with data verification & concurrent regular writes also
> sent while doing copy to verify locking.
> 
> Which also reminds me that I have not seen any change to mq-deadline zone
> write locking for this series. What is the assumption ? That users should
> not be issuing writes when a copy is on-going ? What a bout the reverse
> case ? at the very least, it seems that blk_issue_copy() should be taking
> the zone write lock.
> 
I think you posted this comment in this thread instead of posting it in
the copy offload thread.

>> I will make sure to add my private tree for zonefs in my cover letter in
>> the next rev. But even without that change, a typical emulated npo2
>> device should work fine because the changes are applicable only for
>> "runt" zones.
> 
>