linux-kernel - Re: [PATCH 2/2] sched/fair: Remove cfs_rq_tg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 29 Apr 2022 09:53:08 +0100
From:   Qais Yousef <qais.yousef@....com>
To:     "Peter Zijlstra (Intel)" <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>
Cc:     Dietmar Eggemann <dietmar.eggemann@....com>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Phil Auld <pauld@...hat.com>,
        Giovanni Gherdovich <ggherdovich@...e.cz>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] sched/fair: Remove cfs_rq_tg_path()

+CC lkml

On 04/28/22 15:43, Qais Yousef wrote:
> From: Dietmar Eggemann <dietmar.eggemann@....com>
> 
> cfs_rq_tg_path() is used by a tracepoint-to traceevent (tp-2-te)
> converter to format the path of a taskgroup or autogroup respectively.
> It doesn't have any in-kernel users after the removal of the
> sched_trace_cfs_rq_path() helper function.
> 
> cfs_rq_tg_path() can be coded in a tp-2-te converter.
> 
> Remove it from kernel/sched/fair.c.
> 
> Signed-off-by: Dietmar Eggemann <dietmar.eggemann@....com>
> Signed-off-by: Qais Yousef <qais.yousef@....com>
> ---
>  kernel/sched/fair.c | 19 -------------------
>  1 file changed, 19 deletions(-)
> 
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index ff1177a4a286..7487737c1275 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -313,19 +313,6 @@ const struct sched_class fair_sched_class;
>  #define for_each_sched_entity(se) \
>  		for (; se; se = se->parent)
>  
> -static inline void cfs_rq_tg_path(struct cfs_rq *cfs_rq, char *path, int len)
> -{
> -	if (!path)
> -		return;
> -
> -	if (cfs_rq && task_group_is_autogroup(cfs_rq->tg))
> -		autogroup_path(cfs_rq->tg, path, len);
> -	else if (cfs_rq && cfs_rq->tg->css.cgroup)
> -		cgroup_path(cfs_rq->tg->css.cgroup, path, len);
> -	else
> -		strlcpy(path, "(null)", len);
> -}
> -
>  static inline bool list_add_leaf_cfs_rq(struct cfs_rq *cfs_rq)
>  {
>  	struct rq *rq = rq_of(cfs_rq);
> @@ -493,12 +480,6 @@ static int se_is_idle(struct sched_entity *se)
>  #define for_each_sched_entity(se) \
>  		for (; se; se = NULL)
>  
> -static inline void cfs_rq_tg_path(struct cfs_rq *cfs_rq, char *path, int len)
> -{
> -	if (path)
> -		strlcpy(path, "(null)", len);
> -}
> -
>  static inline bool list_add_leaf_cfs_rq(struct cfs_rq *cfs_rq)
>  {
>  	return true;
> -- 
> 2.25.1
>