linux-kernel - Re: [PATCH] omapdss: HDMI: simplify the return expression of hdmi_init_pll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3deffccf-1708-60bf-2b63-7a77305ec7e6@ideasonboard.com>
Date:   Fri, 29 Apr 2022 13:25:37 +0300
From:   Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
To:     cgel.zte@...il.com
Cc:     airlied@...ux.ie, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, Minghao Chi <chi.minghao@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] omapdss: HDMI: simplify the return expression of
 hdmi_init_pll_data()

On 29/04/2022 12:01, cgel.zte@...il.com wrote:
> From: Minghao Chi <chi.minghao@....com.cn>
> 
> Simplify the return expression.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@....com.cn>
> ---
>   drivers/gpu/drm/omapdrm/dss/hdmi_pll.c | 7 +------
>   1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi_pll.c b/drivers/gpu/drm/omapdrm/dss/hdmi_pll.c
> index eea719243eaf..10c6b3e492d3 100644
> --- a/drivers/gpu/drm/omapdrm/dss/hdmi_pll.c
> +++ b/drivers/gpu/drm/omapdrm/dss/hdmi_pll.c
> @@ -131,7 +131,6 @@ static int hdmi_init_pll_data(struct dss_device *dss,
>   {
>   	struct dss_pll *pll = &hpll->pll;
>   	struct clk *clk;
> -	int r;
>   
>   	clk = devm_clk_get(&pdev->dev, "sys_clk");
>   	if (IS_ERR(clk)) {
> @@ -151,11 +150,7 @@ static int hdmi_init_pll_data(struct dss_device *dss,
>   
>   	pll->ops = &hdmi_pll_ops;
>   
> -	r = dss_pll_register(dss, pll);
> -	if (r)
> -		return r;
> -
> -	return 0;
> +	return dss_pll_register(dss, pll);
>   }

This is a rather pointless change, and I personally like the current 
style better.

  Tomi