linux-kernel - [trondmy-nfs-2.6:testing 4/10] net/sunrpc/xprtsock.c:1436:23: warning: variable 'transport' is uninitialized when used here

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 29 Apr 2022 09:15:55 +0800
From:   kernel test robot <lkp@...el.com>
To:     Trond Myklebust <trond.myklebust@...merspace.com>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org
Subject: [trondmy-nfs-2.6:testing 4/10] net/sunrpc/xprtsock.c:1436:23:
 warning: variable 'transport' is uninitialized when used here

tree:   git://git.linux-nfs.org/projects/trondmy/nfs-2.6.git testing
head:   b44c0c653b27127aba20075ef53b0d641a36a3ae
commit: 8869b563cd42a4cb725604322454ed4fb29a0c18 [4/10] SUNRPC: Ensure timely close of disconnected AF_LOCAL sockets
config: x86_64-randconfig-a012 (https://download.01.org/0day-ci/archive/20220429/202204290947.alhq7Gbj-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project c59473aacce38cd7dd77eebceaf3c98c5707ab3b)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git remote add trondmy-nfs-2.6 git://git.linux-nfs.org/projects/trondmy/nfs-2.6.git
        git fetch --no-tags trondmy-nfs-2.6 testing
        git checkout 8869b563cd42a4cb725604322454ed4fb29a0c18
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash net/sunrpc/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from net/sunrpc/xprtsock.c:36:
   In file included from include/linux/sunrpc/clnt.h:20:
   In file included from include/linux/sunrpc/sched.h:19:
   include/linux/sunrpc/xdr.h:734:10: warning: result of comparison of constant 4611686018427387903 with expression of type '__u32' (aka 'unsigned int') is always false [-Wtautological-constant-out-of-range-compare]
           if (len > SIZE_MAX / sizeof(*p))
               ~~~ ^ ~~~~~~~~~~~~~~~~~~~~~
>> net/sunrpc/xprtsock.c:1436:23: warning: variable 'transport' is uninitialized when used here [-Wuninitialized]
                   xs_run_error_worker(transport, XPRT_SOCK_WAKE_DISCONNECT);
                                       ^~~~~~~~~
   net/sunrpc/xprtsock.c:1429:29: note: initialize the variable 'transport' to silence this warning
           struct sock_xprt *transport;
                                      ^
                                       = NULL
   2 warnings generated.


vim +/transport +1436 net/sunrpc/xprtsock.c

  1420	
  1421	/**
  1422	 * xs_local_state_change - callback to handle AF_LOCAL socket state changes
  1423	 * @sk: socket whose state has changed
  1424	 *
  1425	 */
  1426	static void xs_local_state_change(struct sock *sk)
  1427	{
  1428		struct rpc_xprt *xprt;
  1429		struct sock_xprt *transport;
  1430	
  1431		if (!(xprt = xprt_from_sock(sk)))
  1432			return;
  1433		if (sk->sk_shutdown & SHUTDOWN_MASK) {
  1434			clear_bit(XPRT_CONNECTED, &xprt->state);
  1435			/* Trigger the socket release */
> 1436			xs_run_error_worker(transport, XPRT_SOCK_WAKE_DISCONNECT);
  1437		}
  1438	}
  1439	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp