linux-kernel - Re: [RFC PATCH v4 25/37] arm64: bpf: Skip validation of ___bpf_prog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YmvIZG5Ke6vElb/e@hirez.programming.kicks-ass.net>
Date:   Fri, 29 Apr 2022 13:13:40 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Chen Zhongjin <chenzhongjin@...wei.com>
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-arch@...r.kernel.org, jthierry@...hat.com,
        catalin.marinas@....com, will@...nel.org, masahiroy@...nel.org,
        jpoimboe@...hat.com, ycote@...hat.com, herbert@...dor.apana.org.au,
        mark.rutland@....com, davem@...emloft.net, ardb@...nel.org,
        maz@...nel.org, tglx@...utronix.de, luc.vanoostenryck@...il.com
Subject: Re: [RFC PATCH v4 25/37] arm64: bpf: Skip validation of
 ___bpf_prog_run

On Fri, Apr 29, 2022 at 05:43:43PM +0800, Chen Zhongjin wrote:
> There is a jump table encoded in ___bpf_prog_run and objtool-arm64
> can't deal with it now. Skip validate it for arm64.

But, but, but, an earlier patch did -fno-jump-tables!

> 
> Signed-off-by: Chen Zhongjin <chenzhongjin@...wei.com>
> ---
>  kernel/bpf/core.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/kernel/bpf/core.c b/kernel/bpf/core.c
> index 13e9dbeeedf3..d702f1d83176 100644
> --- a/kernel/bpf/core.c
> +++ b/kernel/bpf/core.c
> @@ -2022,6 +2022,9 @@ static u64 ___bpf_prog_run(u64 *regs, const struct bpf_insn *insn)
>  		BUG_ON(1);
>  		return 0;
>  }
> +#ifdef CONFIG_ARM64
> +STACK_FRAME_NON_STANDARD(___bpf_prog_run);
> +#endif
>  
>  #define PROG_NAME(stack_size) __bpf_prog_run##stack_size
>  #define DEFINE_BPF_PROG_RUN(stack_size) \
> -- 
> 2.17.1
>