linux-kernel - Re: [PATCH] firmware: xilinx: add support for sd/usb/gem config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bdf10e9f-37e3-ee1d-481b-9285fa133a9e@xilinx.com>
Date:   Fri, 29 Apr 2022 13:34:33 +0200
From:   Michal Simek <michal.simek@...inx.com>
To:     Ronak Jain <ronak.jain@...inx.com>, <michal.simek@...inx.com>,
        <linux-kernel@...r.kernel.org>
CC:     <gregkh@...uxfoundation.org>, <corbet@....net>,
        <linux-arm-kernel@...ts.infradead.org>, <arnd@...db.de>,
        <lakshmi.sai.krishna.potthuri@...inx.com>, <radheys@...inx.com>,
        <agodhasa@...inx.com>
Subject: Re: [PATCH] firmware: xilinx: add support for sd/usb/gem config



On 4/29/22 12:16, Ronak Jain wrote:
> Add new APIs in firmware to configure SD/GEM/USB registers. Internally
> it calls PM IOCTL for below SD/GEM/USB register configuration:
> - SD/EMMC select
> - SD slot type
> - SD base clock
> - SD 8 bit support
> - GEM SGMII Mode
> - SD fixed config
> - GEM fixed config
> - USB fixed config
> 
> Signed-off-by: Ronak Jain <ronak.jain@...inx.com>

I think it was said that you shouldn't send interface changes without any user.
It means every function you add should be also used.

Thanks,
Michal