linux-kernel - Re: [PATCH] mm/swapops: make is_pmd_migration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Ymvol9Ffa5/fh7Jw@xz-m1.local>
Date:   Fri, 29 Apr 2022 09:31:03 -0400
From:   Peter Xu <peterx@...hat.com>
To:     Hongchen Zhang <zhanghongchen@...ngson.cn>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Alistair Popple <apopple@...dia.com>,
        Ralph Campbell <rcampbell@...dia.com>,
        Naoya Horiguchi <naoya.horiguchi@....com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/swapops: make is_pmd_migration_entry more strict

On Fri, Apr 29, 2022 at 10:23:08AM +0800, Hongchen Zhang wrote:
> Hello Peter,

Hi, Hongchen,

>   (1) the pmd passed to __split_huge_pmd_locked may be a none pmd,so it may
> be wrongly treated as a pmd migration entry.

With !ARCH_ENABLE_THP_MIGRATION is_pmd_migration_entry() returns 0
constantly.

>   (2) we are preparing to support thp migration on MIPS.

Makes sense (to not have Fixes then).  It'll be great if the objective of
the patch will be mentioned in the future.

Thanks for answering!

-- 
Peter Xu