linux-kernel - Re: [PATCH] scsi: elx: efct: remove unnecessary memset in efct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 30 Apr 2022 17:48:06 +1000 (AEST)
From:   Finn Thain <fthain@...ux-m68k.org>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
cc:     Wan Jiabing <wanjiabing@...o.com>,
        James Smart <james.smart@...adcom.com>,
        Ram Vegesna <ram.vegesna@...adcom.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Daniel Wagner <dwagner@...e.de>, linux-scsi@...r.kernel.org,
        target-devel@...r.kernel.org, linux-kernel@...r.kernel.org,
        cocci@...ia.fr
Subject: Re: [PATCH] scsi: elx: efct: remove unnecessary memset in efct_io

On Sat, 30 Apr 2022, Christophe JAILLET wrote:

> Le 18/03/2022 à 15:52, Wan Jiabing a écrit :
> > io->sgl is allocated by kzalloc(). The memory is set to zero.
> > It is unnecessary to call memset again.
> > 
> 
> Hi,
> 
> Nitpick: this kzalloc() should be a kcalloc() to avoid an open-coded
> multiplication when computing the size to allocate.
> 

Seems like kcalloc() conversion could be a separate patch. Perhaps it 
could be done everywhere using a coccinelle script.