linux-kernel - Re: [PATCH] phy: rockchip-inno-usb2: Clean up some inconsistent indenting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2309786.iZASKD2KPV@phil>
Date:   Sat, 30 Apr 2022 15:09:08 +0200
From:   Heiko Stuebner <heiko@...ech.de>
To:     kishon@...com, Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     vkoul@...nel.org, linux-phy@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] phy: rockchip-inno-usb2: Clean up some inconsistent indenting

Am Donnerstag, 21. April 2022, 22:30:38 CEST schrieb Jiapeng Chong:
> Eliminate the follow smatch warning:
> 
> drivers/phy/rockchip/phy-rockchip-inno-usb2.c:1203
> rockchip_usb2phy_probe() warn: inconsistent indenting.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>

Reviewed-by: Heiko Stuebner <heiko@...ech.de>

> ---
>  drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
> index e377b958d9b6..6711659f727c 100644
> --- a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
> +++ b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
> @@ -1200,8 +1200,8 @@ static int rockchip_usb2phy_probe(struct platform_device *pdev)
>  
>  	else {
>  		rphy->grf = syscon_node_to_regmap(dev->parent->of_node);
> -			if (IS_ERR(rphy->grf))
> -				return PTR_ERR(rphy->grf);
> +		if (IS_ERR(rphy->grf))
> +			return PTR_ERR(rphy->grf);
>  	}
>  
>  	if (of_device_is_compatible(np, "rockchip,rv1108-usb2phy")) {
>