linux-kernel - Re: [PATCH net-next v5 1/2] rtnetlink: add extack support in fdb del handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220429184636.0b869ae7@kernel.org>
Date:   Fri, 29 Apr 2022 18:46:36 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Alaa Mohamed <eng.alaamohamedsoliman.am@...il.com>
Cc:     netdev@...r.kernel.org, outreachy@...ts.linux.dev,
        roopa@...dia.com, jdenham@...hat.com, sbrivio@...hat.com,
        jesse.brandeburg@...el.com, anthony.l.nguyen@...el.com,
        davem@...emloft.net, pabeni@...hat.com, vladimir.oltean@....com,
        claudiu.manoil@....com, alexandre.belloni@...tlin.com,
        shshaikh@...vell.com, manishc@...vell.com, razor@...ckwall.org,
        intel-wired-lan@...ts.osuosl.org, linux-kernel@...r.kernel.org,
        UNGLinuxDriver@...rochip.com, GR-Linux-NIC-Dev@...vell.com,
        bridge@...ts.linux-foundation.org
Subject: Re: [PATCH net-next v5 1/2] rtnetlink: add extack support in fdb
 del handlers

On Fri, 29 Apr 2022 14:49:06 +0200 Alaa Mohamed wrote:
> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
> index fde839ef0613..3fccac358198 100644
> --- a/drivers/net/ethernet/intel/ice/ice_main.c
> +++ b/drivers/net/ethernet/intel/ice/ice_main.c
> @@ -5678,7 +5678,7 @@ ice_fdb_add(struct ndmsg *ndm, struct nlattr __always_unused *tb[],
>  static int
>  ice_fdb_del(struct ndmsg *ndm, __always_unused struct nlattr *tb[],
>  	    struct net_device *dev, const unsigned char *addr,
> -	    __always_unused u16 vid)
> +	    __always_unused u16 vid, struct netlink_ext_ack *extack)

You need to update the kdoc on this one.