linux-kernel - Re: [PATCH] perf: make util/data.h self-contained

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Ym1WaannQyQ+Fn3C@kernel.org>
Date:   Sat, 30 Apr 2022 12:31:53 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Yang Jihong <yangjihong1@...wei.com>
Cc:     peterz@...radead.org, mingo@...hat.com, mark.rutland@....com,
        alexander.shishkin@...ux.intel.com, jolsa@...nel.org,
        namhyung@...nel.org, ak@...ux.intel.com, adrian.hunter@...el.com,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf: make util/data.h self-contained

Em Fri, Apr 29, 2022 at 05:05:39PM +0800, Yang Jihong escreveu:
> struct perf_data in util/data.h uses "u64" data type, which is defined in
> "linux/types.h". If only include util/data.h, following compilation error
> occur:
> 
> util/data.h:38:3: error: unknown type name ‘u64’
>    u64    version;
>    ^~~
> 
> Solution: include "linux/types.h." to resolve self-contained issues

Thanks, applied.

- Arnaldo

 
> Fixes: 258031c017c35 (perf header: Add DIR_FORMAT feature to describe directory data)
> Signed-off-by: Yang Jihong <yangjihong1@...wei.com>
> ---
>  tools/perf/util/data.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/perf/util/data.h b/tools/perf/util/data.h
> index c9de82af5584..1402d9657ef2 100644
> --- a/tools/perf/util/data.h
> +++ b/tools/perf/util/data.h
> @@ -4,6 +4,7 @@
>  
>  #include <stdio.h>
>  #include <stdbool.h>
> +#include <linux/types.h>
>  
>  enum perf_data_mode {
>  	PERF_DATA_MODE_WRITE,
> -- 
> 2.30.GIT

-- 

- Arnaldo