linux-kernel - Re: [PATCH] device property: Fix recent breakage of fwnode_get_next_parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ym2aRE/CkLsuJYzM@paasikivi.fi.intel.com>
Date:   Sat, 30 Apr 2022 23:21:24 +0300
From:   Sakari Ailus <sakari.ailus@...ux.intel.com>
To:     Douglas Anderson <dianders@...omium.org>
Cc:     "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
        swboyd@...omium.org,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        freedreno@...ts.freedesktop.org,
        Saravana Kannan <saravanak@...gle.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        linux-arm-msm@...r.kernel.org, Daniel Scally <djrscally@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] device property: Fix recent breakage of
 fwnode_get_next_parent_dev()

On Fri, Apr 29, 2022 at 04:43:47PM -0700, Douglas Anderson wrote:
> Due to a subtle typo, instead of commit 87ffea09470d ("device
> property: Introduce fwnode_for_each_parent_node()") being a no-op
> change, it ended up causing the display on my sc7180-trogdor-lazor
> device from coming up unless I added "fw_devlink=off" to my kernel
> command line. Fix the typo.
> 
> Fixes: 87ffea09470d ("device property: Introduce fwnode_for_each_parent_node()")
> Signed-off-by: Douglas Anderson <dianders@...omium.org>

Good catch, thanks!

Reviewed-by: Sakari Ailus <sakari.ailus@...ux.intel.com>

> ---
> 
>  drivers/base/property.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/base/property.c b/drivers/base/property.c
> index 36401cfe432c..52e85dcb20b5 100644
> --- a/drivers/base/property.c
> +++ b/drivers/base/property.c
> @@ -600,7 +600,7 @@ struct device *fwnode_get_next_parent_dev(struct fwnode_handle *fwnode)
>  	struct device *dev;
>  
>  	fwnode_for_each_parent_node(fwnode, parent) {
> -		dev = get_dev_from_fwnode(fwnode);
> +		dev = get_dev_from_fwnode(parent);
>  		if (dev) {
>  			fwnode_handle_put(parent);
>  			return dev;

-- 
Sakari Ailus