lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:   Sat, 30 Apr 2022 12:00:26 +0800
From:   kernel test robot <lkp@...el.com>
To:     Sven Peter <sven@...npeter.dev>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Hector Martin <marcan@...can.st>
Subject: [asahilinux:nvme-v3 4/6] drivers/soc/apple/sart.c:247:18: warning:
 format '%llx' expects argument of type 'long long unsigned int', but
 argument 3 has type 'phys_addr_t' {aka 'unsigned int'}

tree:   https://github.com/AsahiLinux/linux nvme-v3
head:   ab2e9498dde5a82fa515c5278335de404de4df63
commit: 18cb959d4f944bb410711eda2ff3b5d4eb872b7c [4/6] soc: apple: Add SART driver
config: parisc-allmodconfig (https://download.01.org/0day-ci/archive/20220430/202204301124.xCHwrb3R-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/AsahiLinux/linux/commit/18cb959d4f944bb410711eda2ff3b5d4eb872b7c
        git remote add asahilinux https://github.com/AsahiLinux/linux
        git fetch --no-tags asahilinux nvme-v3
        git checkout 18cb959d4f944bb410711eda2ff3b5d4eb872b7c
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=parisc SHELL=/bin/bash drivers/net/netdevsim/ drivers/soc/apple/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/device.h:15,
                    from include/linux/soc/apple/sart.h:15,
                    from drivers/soc/apple/sart.c:14:
   drivers/soc/apple/sart.c: In function 'apple_sart_add_allowed_region':
>> drivers/soc/apple/sart.c:247:18: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 3 has type 'phys_addr_t' {aka 'unsigned int'} [-Wformat=]
     247 |                  "no free entries left to add [paddr: 0x%llx, size: 0x%zx]\n",
         |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
     110 |                 _p_func(dev, fmt, ##__VA_ARGS__);                       \
         |                              ^~~
   include/linux/dev_printk.h:146:61: note: in expansion of macro 'dev_fmt'
     146 |         dev_printk_index_wrap(_dev_warn, KERN_WARNING, dev, dev_fmt(fmt), ##__VA_ARGS__)
         |                                                             ^~~~~~~
   drivers/soc/apple/sart.c:246:9: note: in expansion of macro 'dev_warn'
     246 |         dev_warn(sart->dev,
         |         ^~~~~~~~
   drivers/soc/apple/sart.c:247:60: note: format string is defined here
     247 |                  "no free entries left to add [paddr: 0x%llx, size: 0x%zx]\n",
         |                                                         ~~~^
         |                                                            |
         |                                                            long long unsigned int
         |                                                         %x
   In file included from include/linux/device.h:15,
                    from include/linux/soc/apple/sart.h:15,
                    from drivers/soc/apple/sart.c:14:
   drivers/soc/apple/sart.c: In function 'apple_sart_remove_allowed_region':
   drivers/soc/apple/sart.c:283:29: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 3 has type 'phys_addr_t' {aka 'unsigned int'} [-Wformat=]
     283 |         dev_warn(sart->dev, "entry [paddr: 0x%llx, size: 0x%zx] not found\n",
         |                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
     110 |                 _p_func(dev, fmt, ##__VA_ARGS__);                       \
         |                              ^~~
   include/linux/dev_printk.h:146:61: note: in expansion of macro 'dev_fmt'
     146 |         dev_printk_index_wrap(_dev_warn, KERN_WARNING, dev, dev_fmt(fmt), ##__VA_ARGS__)
         |                                                             ^~~~~~~
   drivers/soc/apple/sart.c:283:9: note: in expansion of macro 'dev_warn'
     283 |         dev_warn(sart->dev, "entry [paddr: 0x%llx, size: 0x%zx] not found\n",
         |         ^~~~~~~~
   drivers/soc/apple/sart.c:283:49: note: format string is defined here
     283 |         dev_warn(sart->dev, "entry [paddr: 0x%llx, size: 0x%zx] not found\n",
         |                                              ~~~^
         |                                                 |
         |                                                 long long unsigned int
         |                                              %x


vim +247 drivers/soc/apple/sart.c

   219	
   220	int apple_sart_add_allowed_region(struct apple_sart *sart, phys_addr_t paddr,
   221					  size_t size)
   222	{
   223		int i, ret;
   224	
   225		for (i = 0; i < APPLE_SART_MAX_ENTRIES; ++i) {
   226			if (test_bit(i, &sart->protected_entries))
   227				continue;
   228			if (test_and_set_bit(i, &sart->used_entries))
   229				continue;
   230	
   231			ret = sart_set_entry(sart, i, APPLE_SART_FLAGS_ALLOW, paddr,
   232					     size);
   233			if (ret) {
   234				dev_dbg(sart->dev,
   235					"unable to set entry %d to [%pa, 0x%zx]\n",
   236					i, &paddr, size);
   237				clear_bit(i, &sart->used_entries);
   238				return ret;
   239			}
   240	
   241			dev_dbg(sart->dev, "wrote [%pa, 0x%zx] to %d\n", &paddr, size,
   242				i);
   243			return 0;
   244		}
   245	
   246		dev_warn(sart->dev,
 > 247			 "no free entries left to add [paddr: 0x%llx, size: 0x%zx]\n",
   248			 paddr, size);
   249	
   250		return -EBUSY;
   251	}
   252	EXPORT_SYMBOL(apple_sart_add_allowed_region);
   253	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ