linux-kernel - Re: [PATCH] ksmbd: fix reference count leak in smb_check_perm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKYAXd9SdLAB_=P_4L47Gfo_uAE_i98292Rut6=dfBr-zy3nGQ@mail.gmail.com>
Date:   Sat, 30 Apr 2022 13:14:50 +0900
From:   Namjae Jeon <linkinjeon@...nel.org>
To:     Xin Xiong <xiongx18@...an.edu.cn>
Cc:     Steve French <sfrench@...ba.org>, Hyunchul Lee <hyc.lee@...il.com>,
        Sergey Senozhatsky <senozhatsky@...omium.org>,
        linux-cifs@...r.kernel.org, linux-kernel@...r.kernel.org,
        yuanxzhang@...an.edu.cn, Xin Tan <tanxin.ctf@...il.com>
Subject: Re: [PATCH] ksmbd: fix reference count leak in smb_check_perm_dacl()

2022-04-29 17:11 GMT+09:00, Xin Xiong <xiongx18@...an.edu.cn>:
> The issue happens in a specific path in smb_check_perm_dacl(). When
> "id" and "uid" have the same value, the function simply jumps out of
> the loop without decrementing the reference count of the object
> "posix_acls", which is increased by get_acl() earlier. This may
> result in memory leaks.
>
> Fix it by decreasing the reference count of "posix_acls" before
> jumping to label "check_access_bits".
>
> Fixes: 777cad1604d6 ("ksmbd: remove select FS_POSIX_ACL in Kconfig")
> Signed-off-by: Xin Xiong <xiongx18@...an.edu.cn>
> Signed-off-by: Xin Tan <tanxin.ctf@...il.com>
Acked-by: Namjae Jeon <linkinjeon@...nel.org>

Thanks!