linux-kernel - Re: [PATCH v2] MIPS: undefine and redefine cpu_has

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANubcdUxobBn968rtz0z-zZVJQfV5k3PQcdLdXNbsw3mEphk0A@mail.gmail.com>
Date:   Sun, 1 May 2022 10:54:17 +0800
From:   Stephen Zhang <starzhangzsd@...il.com>
To:     "Maciej W. Rozycki" <macro@...am.me.uk>
Cc:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        liam.howlett@...cle.com, ebiederm@...ssion.com, alobakin@...me,
        f.fainelli@...il.com, paul@...pouillou.net, linux@...ck-us.net,
        anemo@....ocn.ne.jp, zhangshida <zhangshida@...inos.cn>,
        linux-kernel@...r.kernel.org, linux-mips@...r.kernel.org
Subject: Re: [PATCH v2] MIPS: undefine and redefine cpu_has_fpu when it is overrided

Maciej W. Rozycki <macro@...am.me.uk> 于2022年4月30日周六 23:38写道：
>
>  Adding a safety check would be a separate improvement.  Please feel free
> to submit one.
>
>  We need to keep fixes and improvements as separate changes.  For one
> fixes can be candidates for backporting while improvements are never
> backported; cf. Documentation/process/stable-kernel-rules.rst.
>
>  I hope this clears your concerns.  Let me know if you have further
> questions.
>
>   Maciej

Thanks for your elaboration.It helps a lot.
I want to submit a v3 patch like:

#if cpu_has_fpu
# error "Forcing `cpu_has_fpu' to non-zero is not supported"
#endif

but this will cause the link error if not combined with the fix:

MIPS: IP30: Remove incorrect `cpu_has_fpu' override

Maybe I should submit one first, and see how it goes then.