linux-kernel - Re: [PATCH v2 4/8] dt-bindings: riscv: microchip: document icicle reference design

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 1 May 2022 11:41:47 +0100
From:   Conor Dooley <mail@...chuod.ie>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        krzk+dt@...nel.org, palmer@...belt.com, robh+dt@...nel.org
Cc:     conor.dooley@...rochip.com, Cyril.Jean@...rochip.com,
        daire.mcnamara@...rochip.com, paul.walmsley@...ive.com,
        aou@...s.berkeley.edu, palmer@...osinc.com, arnd@...db.de,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-riscv@...ts.infradead.org
Subject: Re: [PATCH v2 4/8] dt-bindings: riscv: microchip: document icicle
 reference design



On 01/05/2022 09:57, Krzysztof Kozlowski wrote:
> On 30/04/2022 15:09, Conor Dooley wrote:
>> From: Conor Dooley <conor.dooley@...rochip.com>
>>
>> Add a compatible for the icicle kit's reference design. This represents
>> the FPGA fabric's contents & is versioned to denote which release of the
>> reference design it applies to.
>>
>> Signed-off-by: Conor Dooley <conor.dooley@...rochip.com>
>> Signed-off-by: Conor Dooley <mail@...chuod.ie>
>> ---
>>  .../devicetree/bindings/riscv/microchip.yaml          | 11 +++++++----
>>  1 file changed, 7 insertions(+), 4 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/riscv/microchip.yaml b/Documentation/devicetree/bindings/riscv/microchip.yaml
>> index 3f981e897126..c9d8fcc7a69e 100644
>> --- a/Documentation/devicetree/bindings/riscv/microchip.yaml
>> +++ b/Documentation/devicetree/bindings/riscv/microchip.yaml
>> @@ -17,10 +17,13 @@ properties:
>>    $nodename:
>>      const: '/'
>>    compatible:
>> -    items:
>> -      - enum:
>> -          - microchip,mpfs-icicle-kit
>> -      - const: microchip,mpfs
>> +    oneOf:
>> +      - items:
>> +          - enum:
>> +              - microchip,mpfs-icicle-kit
>> +          - const: microchip,mpfs
> 
> Blank line.
> 
>> +      - items:
>> +          - const: microchip,mpfs-icicle-reference-rtlv2203
> 
> Why is this not compatible with microchip,mpfs?

I guess it should be, I'll add it. Thanks.