linux-kernel - Re: [PATCH] USB / dwc3: remove a possible unnecessary 'out of memory' message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 1 May 2022 17:39:19 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Kushagra Verma <kushagra765@...look.com>
Cc:     balbi@...nel.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB / dwc3: remove a possible unnecessary 'out of
 memory' message

On Sun, May 01, 2022 at 09:01:36PM +0530, Kushagra Verma wrote:
> This patch removes a possible unnecessary out of memory message from
> core.c
> as reported by checkpatch.pl:
>    WARNING: Possible unnecessary 'out of memory' message
> 
> Signed-off-by: Kushagra Verma <kushagra765@...look.com>
> ---
>  drivers/usb/dwc3/core.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index 25c686a752b0..4ee787de2956 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -844,10 +844,8 @@ static void dwc3_set_incr_burst_type(struct dwc3
> *dwc)
>  		return;
>  
>  	vals = kcalloc(ntype, sizeof(u32), GFP_KERNEL);
> -	if (!vals) {
> -		dev_err(dev, "Error to get memory\n");
> +	if (!vals)
>  		return;
> -	}
>  
>  	/* Get INCR burst type, and parse it */
>  	ret = device_property_read_u32_array(dev,
> -- 
> 2.32.0
> 
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch is malformed (tabs converted to spaces, linewrapped, etc.)
  and can not be applied.  Please read the file,
  Documentation/email-clients.txt in order to fix this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot