linux-kernel - Re: [PATCH v2 0/3] binder: Use kmap_local_page() in binder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Ym4fAd501sUmEdLB@iweiny-server>
Date:   Sat, 30 Apr 2022 22:48:08 -0700
From:   ira.weiny@...el.com
To:     "Fabio M. De Francesco" <fmdefrancesco@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Arve Hjønnevåg <arve@...roid.com>,
        Todd Kjos <tkjos@...roid.com>,
        Martijn Coenen <maco@...roid.com>,
        Joel Fernandes <joel@...lfernandes.org>,
        Christian Brauner <brauner@...nel.org>,
        Hridya Valsaraju <hridya@...gle.com>,
        Suren Baghdasaryan <surenb@...gle.com>,
        linux-kernel@...r.kernel.org,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>
Subject: Re: [PATCH v2 0/3] binder: Use kmap_local_page() in binder_alloc.c

On Mon, Apr 25, 2022 at 07:57:51PM +0200, Fabio M. De Francesco wrote:
> Use kmap_local_page() in binder_alloc.c because kmap() and kmap_atomic()
> are being deprecated and kmap_local_page() is preferred where it is
> feasible.
> 
> With kmap_local_page(), the mapping is per thread, CPU local and not
> globally visible. Furthermore, the mapping can be acquired from any
> context, including interrupts.

For the series:

Reviewed-by: Ira Weiny <ira.weiny@...el.com>

> 
> Fabio M. De Francesco (3):
>   binder: Use memset_page() in binder_alloc_clear_buf()
>   binder: Use kmap_local_page() in binder_alloc_copy_user_to_buffer()
>   binder: Use memcpy_{to,from}_page() in binder_alloc_do_buffer_copy()
> 
>  drivers/android/binder_alloc.c | 22 +++++-----------------
>  1 file changed, 5 insertions(+), 17 deletions(-)
> 
> -- 
> 2.34.1
>