linux-kernel - Re: [PATCH V9 10/24] LoongArch: Add exception/interrupt handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2a534c89b3c905a34f947fb2739d58c9373bb915.camel@mengyan1223.wang>
Date:   Mon, 02 May 2022 01:08:41 +0800
From:   Xi Ruoyao <xry111@...gyan1223.wang>
To:     Huacai Chen <chenhuacai@...ngson.cn>,
        Arnd Bergmann <arnd@...db.de>,
        Andy Lutomirski <luto@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        David Airlie <airlied@...ux.ie>,
        Jonathan Corbet <corbet@....net>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     linux-arch@...r.kernel.org, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, Xuefeng Li <lixuefeng@...ngson.cn>,
        Yanteng Si <siyanteng@...ngson.cn>,
        Huacai Chen <chenhuacai@...il.com>,
        Guo Ren <guoren@...nel.org>, Xuerui Wang <kernel@...0n.name>,
        Jiaxun Yang <jiaxun.yang@...goat.com>
Subject: Re: [PATCH V9 10/24] LoongArch: Add exception/interrupt handling

On Mon, 2022-05-02 at 00:27 +0800, Xi Ruoyao wrote:
> On Sat, 2022-04-30 at 17:05 +0800, Huacai Chen wrote:
> > +struct acpi_madt_lio_pic;
> > +struct acpi_madt_eio_pic;
> > +struct acpi_madt_ht_pic;
> > +struct acpi_madt_bio_pic;
> > +struct acpi_madt_msi_pic;
> > +struct acpi_madt_lpc_pic;
> 
> Where are those defined?  I can't find them and the compilation fails
> with:
> 
> arch/loongarch/kernel/irq.c: In function ‘find_pch_pic’:
> arch/loongarch/kernel/irq.c:48:32: error: invalid use of undefined
> type ‘struct acpi_madt_bio_pic’
>    48 |                 start = irq_cfg->gsi_base;
>       |                                ^~
> arch/loongarch/kernel/irq.c:49:32: error: invalid use of undefined
> type ‘struct acpi_madt_bio_pic’
>    49 |                 end   = irq_cfg->gsi_base + irq_cfg->size;
>       |                                ^~
> arch/loongarch/kernel/irq.c:49:52: error: invalid use of undefined
> type ‘struct acpi_madt_bio_pic’
>    49 |                 end   = irq_cfg->gsi_base + irq_cfg->size;
>       |                                                    ^~

Alright, my bad... I didn't realize the LoongArch patches are splitted
into multiple series for multiple lists.  But is this the SOP of kernel
patch reviewing?  Would it be easier to just send one series and CC all
relevent lists?

-- 
Xi Ruoyao <xry111@...gyan1223.wang>
School of Aerospace Science and Technology, Xidian University