linux-kernel - Re: [PATCH v2 7/7] ASoC: tpa6130: use i2c_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 1 May 2022 19:08:02 +0200
From:   Stephen Kitt <steve@....org>
To:     Mark Brown <broonie@...nel.org>
Cc:     Liam Girdwood <lgirdwood@...il.com>, Wolfram Sang <wsa@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 7/7] ASoC: tpa6130: use i2c_match_id and simple i2c
 probe

On Mon, 25 Apr 2022 14:26:50 +0100, Mark Brown <broonie@...nel.org> wrote:
> On Fri, Apr 15, 2022 at 06:06:13PM +0200, Stephen Kitt wrote:
> > As part of the ongoing i2c transition to the simple probe
> > ("probe_new"), this patch uses i2c_match_id to retrieve the
> > driver_data for the probed device. The id parameter is thus no longer
> > necessary and the simple probe can be used instead.  
> 
> This breaks the build for omap2plus defconfig on arm:
> 
> /build/stage/linux/sound/soc/codecs/tpa6130a2.c:322:11: error:
> initialization of ‘int (*)(struct i2c_client *, const struct i2c_device_id
> *)’ from incompatible pointer type ‘int (*)(struct i2c_client *)’
> [-Werror=incompatible-pointer-types] 322 |  .probe = tpa6130a2_probe, |
>       ^~~~~~~~~~~~~~~
> /build/stage/linux/sound/soc/codecs/tpa6130a2.c:322:11: note: (near
> initialization for ‘tpa6130a2_i2c_driver.probe’) cc1: some warnings being
> treated as errors
> 
> You forgot to move probe() to probe_new() in the driver struct.

Sorry about that, I obviously missed that file in my build.

v3 will be on its way soon (only for that commit)...

Regards,

Stephen

Content of type "application/pgp-signature" skipped