linux-kernel - [PATCH v5 2/2] staging: vt6655: Added missing BE support in CARDbGetCurrentTSF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <25c80e3eb889ef2e530f26b4a97a9f5fe88e01ab.1651431640.git.philipp.g.hortmann@gmail.com>
Date:   Sun, 1 May 2022 21:12:29 +0200
From:   Philipp Hortmann <philipp.g.hortmann@...il.com>
To:     Forest Bond <forest@...ttletooquiet.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        David Laight <David.Laight@...LAB.COM>
Subject: [PATCH v5 2/2] staging: vt6655: Added missing BE support in
 CARDbGetCurrentTSF

Added missing big-endian support in CARDbGetCurrentTSF.

Reported-by: David Laight <David.Laight@...LAB.COM>
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@...il.com>
---
V1 -> V2: Replaced #ifdef __BIG_ENDIAN with le64_to_cpu()
          Updated below example

Code for testing:
low = ioread32(iobase + MAC_REG_TSFCNTR);
high = ioread32(iobase + MAC_REG_TSFCNTR + 4);
*pqwCurrTSF = le64_to_cpu(low + ((u64)high << 32));
dev_info(&priv->pcid->dev, "CARDbGetCurrentTSF little endian: 0x%016llx", *pqwCurrTSF);
dev_info(&priv->pcid->dev, "CARDbGetCurrentTSF big-endian:    0x%016llx", be64_to_cpu(low + ((u64)high << 32)));

Log of the microsecond counter:
vt6655 0000:01:05.0: CARDbGetCurrentTSF little endian: 0x00 00 00 03 6a ce 0d 7d
vt6655 0000:01:05.0: CARDbGetCurrentTSF big-endian:    0x7d 0d ce 6a 03 00 00 00
vt6655 0000:01:05.0: CARDbGetCurrentTSF little endian: 0x00 00 00 03 6a ce 0d 89
vt6655 0000:01:05.0: CARDbGetCurrentTSF big-endian:    0x89 0d ce 6a 03 00 00 00
---
 drivers/staging/vt6655/card.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index 0dd13e475d6b..431890e6b8d2 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -756,7 +756,7 @@ bool CARDbGetCurrentTSF(struct vnt_private *priv, u64 *pqwCurrTSF)
 		return false;
 	low = ioread32(iobase + MAC_REG_TSFCNTR);
 	high = ioread32(iobase + MAC_REG_TSFCNTR + 4);
-	*pqwCurrTSF = low + ((u64)high << 32);
+	*pqwCurrTSF = le64_to_cpu(low + ((u64)high << 32));
 
 	return true;
 }
-- 
2.25.1