linux-kernel - Re: [PATCH v2] dt-bindings: arm: mediatek: mmsys: refine power and gce properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cf3062c9ebc69642bdc16ce32ed3260486969b04.camel@mediatek.com>
Date:   Sun, 1 May 2022 16:26:24 +0800
From:   Jason-JH Lin <jason-jh.lin@...iatek.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
CC:     Fabien Parent <fparent@...libre.com>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>, CK Hu <ck.hu@...iatek.com>,
        Rex-BC Chen <rex-bc.chen@...iatek.com>,
        Nancy Lin <nancy.lin@...iatek.com>,
        Singo Chang <singo.chang@...iatek.com>,
        <Project_Global_Chrome_Upstream_Group@...iatek.com>,
        Cellopoint <cellopoint.kai@...il.com>
Subject: Re: [PATCH v2] dt-bindings: arm: mediatek: mmsys: refine power and
 gce properties

Hi Krzysztof,

Thanks for the reviews.

On Fri, 2022-04-29 at 22:58 +0200, Krzysztof Kozlowski wrote:
> On 29/04/2022 10:30, Jason-JH.Lin wrote:
> > Power:
> >   Refine description and add item number for power-domains
> > property.
> > 
> > GCE:
> >   Refine description and add item number for mboxes property and
> >   mediatek,gce-client-reg property.
> > 
> > Fixes: 1da90b8a7bae ("dt-bindings: arm: mediatek: mmsys: add power
> > and gce properties")
> > Signed-off-by: Jason-JH.Lin <jason-jh.lin@...iatek.com>

[snip]
 
> >    mboxes:
> > +    minItems: 1
> > +    maxItems: 24
> 
> Wait, no, I wrote it should be 16 for one device and 24 for other,
> not
> 24 for all...
> 

Ok, I thought maxItems: 24 contained 16, but it's not clear enough.


I'm not sure how to describe different maxItems for different
platforms. Does it come like this?

1. Remove the maxItems in mboxes property.
2. Add the allOf condition before the line "additionalProperties:
false". E.g.

allOf:
  - if:
      properties:
        compatible:
          contains:
            const: mediatek,mt8173-mmsys
    then:
      properties:
        mboxes:
          maxItems: 16
    else:
      properties:
        mboxes:
          maxItems: 24

additionalProperties: false
...


Regards,
Jason-JH.Lin

> Best regards,
> Krzysztof
-- 
Jason-JH Lin <jason-jh.lin@...iatek.com>