linux-kernel - Re: [PATCH v2 1/9] ARM: dts: zynq-7000: drop useless 'dma-channels/requests' properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a838f962-354c-9dcf-c0dc-80d1a6cd4fc3@xilinx.com>
Date:   Mon, 2 May 2022 09:27:18 +0200
From:   Michal Simek <michal.simek@...inx.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        Dinh Nguyen <dinguyen@...nel.org>,
        Michal Simek <michal.simek@...inx.com>,
        Liviu Dudau <liviu.dudau@....com>,
        Sudeep Holla <sudeep.holla@....com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        Broadcom Kernel Team <bcm-kernel-feedback-list@...adcom.com>,
        <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-samsung-soc@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC:     Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v2 1/9] ARM: dts: zynq-7000: drop useless
 'dma-channels/requests' properties



On 4/30/22 14:18, Krzysztof Kozlowski wrote:
> The pl330 DMA controller provides number of DMA channels and requests
> through its registers, so duplicating this information (with a chance of
> mistakes) in DTS is pointless.  Additionally the DTS used always wrong
> property names which causes DT schema check failures - the bindings
> documented 'dma-channels' and 'dma-requests' properties without leading
> hash sign.
> 
> Reported-by: Rob Herring <robh@...nel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> ---
> 
> Not adding acquired review tag because of significant change.
> ---
>   arch/arm/boot/dts/zynq-7000.dtsi | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
> index 47c2a4b14c06..c193264a86ff 100644
> --- a/arch/arm/boot/dts/zynq-7000.dtsi
> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
> @@ -343,8 +343,6 @@ dmac_s: dmac@...03000 {
>   			             <0 40 4>, <0 41 4>,
>   			             <0 42 4>, <0 43 4>;
>   			#dma-cells = <1>;
> -			#dma-channels = <8>;
> -			#dma-requests = <4>;
>   			clocks = <&clkc 27>;
>   			clock-names = "apb_pclk";
>   		};

Acked-by: Michal Simek <michal.simek@....com>

If you can take it via your tree that would be great (easier for me than sending 
pull request with just one patch) but I can also take it.

Thanks,
Michal