linux-kernel - Re: [asahilinux:asahi-soc/rtkit-sart-nvme 4/6] drivers/soc/apple/sart.c:284:4: warning: format specifies type 'unsigned long long' but the argument has type 'phys_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <5291f623-6f0d-4cc0-8358-6aea4e8aa667@www.fastmail.com>
Date:   Mon, 02 May 2022 09:34:44 +0200
From:   "Sven Peter" <sven@...npeter.dev>
To:     "Arnd Bergmann" <arnd@...db.de>,
        "kernel test robot" <lkp@...el.com>
Cc:     clang-built-linux <llvm@...ts.linux.dev>, kbuild-all@...ts.01.org,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
        "Hector Martin" <marcan@...can.st>
Subject: Re: [asahilinux:asahi-soc/rtkit-sart-nvme 4/6] drivers/soc/apple/sart.c:284:4:
 warning: format specifies type 'unsigned long long' but the argument has type
 'phys_addr_t' (aka 'unsigned int')

Hi Arnd,

On Mon, May 2, 2022, at 08:39, Arnd Bergmann wrote:
> On Mon, May 2, 2022 at 2:21 AM kernel test robot <lkp@...el.com> wrote:
>
>>    277
>>    278                  clear_bit(i, &sart->used_entries);
>>    279                  dev_dbg(sart->dev, "cleared entry %d\n", i);
>>    280                  return 0;
>>    281          }
>>    282
>>    283          dev_warn(sart->dev, "entry [paddr: 0x%llx, size: 0x%zx] not found\n",
>>  > 284                   paddr, size);
>>    285
>
> Hi Sven,
>
> to print a phys_addr_t, you should pass the address by reference and use
> the special "%pap" format string modifier. I'm not entirely sure if it should
> actually be a dma_addr_t instead of a phys_addr_t. If the type gets changed,
> the format string would become "%pad".

I've been using %pa for all other prints in this file since v1 and just
missed this one for some reason. I'm a bit confused why the bots found this last
one only now but I'll fix it as well.


Thanks,

Sven