linux-kernel - Re: [PATCH] serial: 8250: dw: Fix NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Ym/KxaRfOaAS8Tzq@smile.fi.intel.com>
Date:   Mon, 2 May 2022 15:12:53 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Emil Renner Berthing <kernel@...il.dk>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] serial: 8250: dw: Fix NULL pointer dereference

On Mon, May 02, 2022 at 02:56:21PM +0300, Heikki Krogerus wrote:
> dw8250_platform_data is only used on DT platforms for now.

Ah, good catch, Heikki!
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Thanks

> Fixes: 4a218b277fdb ("serial: 8250: dw: Create a generic platform data structure")
> Signed-off-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> ---
> Hi,
> 
> I'm sorry, I have to resend this (to you guys).
> I left out the mailing lists.
> 
> Br,
> ---
>  drivers/tty/serial/8250/8250_dw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
> index 0cf1a99dc1244..31422e44c64ff 100644
> --- a/drivers/tty/serial/8250/8250_dw.c
> +++ b/drivers/tty/serial/8250/8250_dw.c
> @@ -433,9 +433,9 @@ static void dw8250_prepare_rx_dma(struct uart_8250_port *p)
>  static void dw8250_quirks(struct uart_port *p, struct dw8250_data *data)
>  {
>  	struct device_node *np = p->dev->of_node;
> -	unsigned int quirks = data->pdata->quirks;
>  
>  	if (np) {
> +		unsigned int quirks = data->pdata->quirks;
>  		int id;
>  
>  		/* get index of serial line, if found in DT aliases */
> -- 
> 2.35.1
> 

-- 
With Best Regards,
Andy Shevchenko