[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <260b95e8-74bf-9460-cf0d-7e3df1b1a3c7@opensource.wdc.com>
Date: Mon, 2 May 2022 21:14:34 +0900
From: Damien Le Moal <damien.lemoal@...nsource.wdc.com>
To: Nitesh Shetty <nj.shetty@...sung.com>
Cc: linux-scsi@...r.kernel.org, nitheshshetty@...il.com,
linux-kernel@...r.kernel.org, linux-nvme@...ts.infradead.org,
linux-block@...r.kernel.org, dm-devel@...hat.com,
linux-fsdevel@...r.kernel.org
Subject: Re: [dm-devel] [PATCH v4 00/10] Add Copy offload support
On 2022/04/27 21:49, Nitesh Shetty wrote:
> O Wed, Apr 27, 2022 at 11:19:48AM +0900, Damien Le Moal wrote:
>> On 4/26/22 19:12, Nitesh Shetty wrote:
>>> The patch series covers the points discussed in November 2021 virtual call
>>> [LSF/MM/BFP TOPIC] Storage: Copy Offload[0].
>>> We have covered the Initial agreed requirements in this patchset.
>>> Patchset borrows Mikulas's token based approach for 2 bdev
>>> implementation.
>>>
>>> Overall series supports –
>>>
>>> 1. Driver
>>> - NVMe Copy command (single NS), including support in nvme-target (for
>>> block and file backend)
>>
>> It would also be nice to have copy offload emulation in null_blk for testing.
>>
>
> We can plan this in next phase of copy support, once this series settles down.
Why ? How do you expect people to test simply without null_blk ? Sutre, you said
QEMU can be used. But if copy offload is not upstream for QEMU either, there is
no easy way to test.
Adding that support to null_blk would not be hard at all.
--
Damien Le Moal
Western Digital Research
Powered by blists - more mailing lists