linux-kernel - Re: [PATCH V6 6/8] x86/entry: Convert SWAPGS to swapgs and remove the definition of SWAPGS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3db51f9f-317a-352a-4214-0f159b6cd34c@suse.com>
Date:   Mon, 2 May 2022 14:18:35 +0200
From:   Juergen Gross <jgross@...e.com>
To:     Borislav Petkov <bp@...en8.de>,
        Lai Jiangshan <jiangshanlai@...il.com>
Cc:     linux-kernel@...r.kernel.org,
        Peter Zijlstra <peterz@...radead.org>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Andy Lutomirski <luto@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>, x86@...nel.org,
        Lai Jiangshan <jiangshan.ljs@...group.com>,
        Ingo Molnar <mingo@...hat.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        "Kirill A. Shutemov" <kirill@...temov.name>
Subject: Re: [PATCH V6 6/8] x86/entry: Convert SWAPGS to swapgs and remove the
 definition of SWAPGS

On 29.04.22 11:56, Borislav Petkov wrote:
> On Thu, Apr 21, 2022 at 10:10:53PM +0800, Lai Jiangshan wrote:
>> diff --git a/arch/x86/entry/entry_64_compat.S b/arch/x86/entry/entry_64_compat.S
>> index 4fdb007cddbd..c5aeb0819707 100644
>> --- a/arch/x86/entry/entry_64_compat.S
>> +++ b/arch/x86/entry/entry_64_compat.S
>> @@ -50,7 +50,7 @@ SYM_CODE_START(entry_SYSENTER_compat)
>>   	UNWIND_HINT_EMPTY
>>   	ENDBR
>>   	/* Interrupts are off on entry. */
>> -	SWAPGS
>> +	swapgs
>>   
>>   	pushq	%rax
>>   	SWITCH_TO_KERNEL_CR3 scratch_reg=%rax
> 
> I'm not sure about this: why can't XENPV do a 32-bit syscall through the vdso?

The syscall will land in the hypervisor, which then will activate
the related registered callback (xen_sysenter_target).

> Also, looking at this, Jürgen, it looks kinda spaghetti to me:
> 
> entry_SYSENTER_compat
> 
> ...
> 
>          /* XEN PV guests always use IRET path */
>          ALTERNATIVE "testl %eax, %eax; jz swapgs_restore_regs_and_return_to_usermode", \
>                      "jmp swapgs_restore_regs_and_return_to_usermode", X86_FEATURE_XENPV
> 
> 
> then at that swapgs_restore_regs_and_return_to_usermode label:
> 
> #ifdef CONFIG_XEN_PV
>          ALTERNATIVE "", "jmp xenpv_restore_regs_and_return_to_usermode", X86_FEATURE_XENPV
> #endif
> 
> 
> Can we simply jump directly to xenpv_restore_regs_and_return_to_usermode
> from entry_SYSENTER_compat or is that CONFIG_DEBUG_ENTRY chunk there
> needed?

I wouldn't insist on the CONFIG_DEBUG_ENTRY chunk.


Juergen

Download attachment "OpenPGP_0xB0DE9DD628BF132F.asc" of type "application/pgp-keys" (3099 bytes)

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (496 bytes)