linux-kernel - Re: [PATCH 2/3] drm/fb-helper: Rename preferred_bpp drm_fbdev_generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 2 May 2022 15:28:25 +0200
From:   Javier Martinez Canillas <javierm@...hat.com>
To:     Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc:     Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Emma Anholt <emma@...olt.net>,
        Chun-Kuang Hu <chunkuang.hu@...nel.org>,
        David Airlie <airlied@...ux.ie>,
        Laurentiu Palcu <laurentiu.palcu@....nxp.com>,
        Liviu Dudau <liviu.dudau@....com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Gurchetan Singh <gurchetansingh@...omium.org>,
        Paul Cercueil <paul@...pouillou.net>,
        Gerd Hoffmann <kraxel@...hat.com>,
        Shawn Guo <shawnguo@...nel.org>,
        linux-stm32@...md-mailman.stormreply.com,
        Jerome Brunet <jbrunet@...libre.com>,
        Marek Vasut <marex@...x.de>, Hao Fang <fanghao11@...wei.com>,
        linux-aspeed@...ts.ozlabs.org,
        Samuel Holland <samuel@...lland.org>,
        Kevin Hilman <khilman@...libre.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Alexey Brodkin <abrodkin@...opsys.com>,
        Michal Simek <michal.simek@...inx.com>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Xinliang Liu <xinliang.liu@...aro.org>,
        Chen-Yu Tsai <wens@...e.org>, Joel Stanley <joel@....id.au>,
        Dave Airlie <airlied@...hat.com>,
        Xinwei Kong <kong.kongxinwei@...ilicon.com>,
        virtualization@...ts.linux-foundation.org,
        NXP Linux Team <linux-imx@....com>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        Raphael Gallais-Pou <raphael.gallais-pou@...s.st.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        Chen Feng <puck.chen@...ilicon.com>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Alison Wang <alison.wang@....com>, linux-mips@...r.kernel.org,
        Sam Ravnborg <sam@...nborg.org>,
        Hans de Goede <hdegoede@...hat.com>,
        linux-mediatek@...ts.infradead.org,
        dri-devel@...ts.freedesktop.org,
        Alain Volmat <alain.volmat@...s.st.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        linux-amlogic@...ts.infradead.org,
        Mario Limonciello <mario.limonciello@....com>,
        Evan Quan <evan.quan@....com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Yong Wu <yong.wu@...iatek.com>,
        linux-arm-kernel@...ts.infradead.org,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        linux-sunxi@...ts.linux.dev, amd-gfx@...ts.freedesktop.org,
        Tomi Valkeinen <tomba@...nel.org>,
        Hyun Kwon <hyun.kwon@...inx.com>,
        Boris Brezillon <bbrezillon@...nel.org>,
        Andrew Jeffery <andrew@...id.au>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Yannick Fertre <yannick.fertre@...s.st.com>,
        "Pan, Xinhui" <Xinhui.Pan@....com>, linux-kernel@...r.kernel.org,
        Claudiu Beznea <claudiu.beznea@...rochip.com>,
        linux-renesas-soc@...r.kernel.org,
        Solomon Chiu <solomon.chiu@....com>,
        Kieran Bingham <kieran.bingham+renesas@...asonboard.com>,
        Philippe Cornu <philippe.cornu@...s.st.com>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Alex Deucher <alexander.deucher@....com>,
        Tian Tao <tiantao6@...ilicon.com>,
        spice-devel@...ts.freedesktop.org, Jyri Sarha <jyri.sarha@....fi>,
        Christian König <christian.koenig@....com>
Subject: Re: [PATCH 2/3] drm/fb-helper: Rename preferred_bpp
 drm_fbdev_generic_setup() parameter

Hello Laurent,

On 5/2/22 13:34, Laurent Pinchart wrote:
> Hi Javier,
> 
> Thank you for the patch.
> 

Thanks a lot for your feedback.

[snip]

>> +++ b/drivers/gpu/drm/drm_fb_helper.c
>> @@ -2501,8 +2501,16 @@ static const struct drm_client_funcs drm_fbdev_client_funcs = {
>>  /**
>>   * drm_fbdev_generic_setup() - Setup generic fbdev emulation
>>   * @dev: DRM device
>> - * @preferred_bpp: Preferred bits per pixel for the device.
>> - *                 @dev->mode_config.preferred_depth is used if this is zero.
>> + * @options: options for the registered framebuffer.
>> + *
>> + * The @options parameter is a multi-field parameter that can contain
>> + * different options for the emulated framebuffer device registered.
>> + *
>> + * The options must be set using DRM_FB_SET_OPTION() and obtained using
>> + * DRM_FB_GET_OPTION(). The options field are the following:
>> + *
>> + * * DRM_FB_BPP: bits per pixel for the device. If the field is not set,
>> + *               @dev->mode_config.preferred_depth is used instead.
> 
> Do I assume correctly that a driver that would need to set multiple
> options would do something like
> 
> 	drm_fbdev_generic_setup(dev, DRM_FB_SET_OPTION(DRM_FB_BPP, 32) |
> 				DRM_FB_SET_OPTION(DRM_FB_FW, 1));
>

That's correct, yes.
 
> ? If so, I would rename DRM_FB_SET_OPTION() to DRM_FB_OPTION() as it's
> computing the value of the option bitfield, it doesn't actually set it.
> Apart from that,
>

Right. I'll rename it.
 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> 

Thanks!

-- 
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat