linux-kernel - Re: [PATCH 2/2] pinctrl: renesas: rzn1: fix possible null-ptr-deref in sh_pfc_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 2 May 2022 15:47:32 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Yang Yingliang <yangyingliang@...wei.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>
Subject: Re: [PATCH 2/2] pinctrl: renesas: rzn1: fix possible null-ptr-deref
 in sh_pfc_map_resources()

Hi Yang,

On Fri, Apr 29, 2022 at 1:22 PM Yang Yingliang <yangyingliang@...wei.com> wrote:
> It will cause null-ptr-deref when using 'res', if platform_get_resource()
> returns NULL, so move using 'res' after devm_ioremap_resource() that
> will check it to avoid null-ptr-deref.
> And use devm_platform_get_and_ioremap_resource() to simplify code.
>
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>

Thanks for your patch!

> --- a/drivers/pinctrl/renesas/pinctrl-rzn1.c
> +++ b/drivers/pinctrl/renesas/pinctrl-rzn1.c
> @@ -865,17 +865,15 @@ static int rzn1_pinctrl_probe(struct platform_device *pdev)
>         ipctl->mdio_func[0] = -1;
>         ipctl->mdio_func[1] = -1;
>
> -       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -       ipctl->lev1_protect_phys = (u32)res->start + 0x400;
> -       ipctl->lev1 = devm_ioremap_resource(&pdev->dev, res);
> +       ipctl->lev1 = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
>         if (IS_ERR(ipctl->lev1))
>                 return PTR_ERR(ipctl->lev1);
> +       ipctl->lev1_protect_phys = (u32)res->start + 0x400;
>
> -       res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> -       ipctl->lev2_protect_phys = (u32)res->start + 0x400;
> -       ipctl->lev2 = devm_ioremap_resource(&pdev->dev, res);
> +       ipctl->lev2 = devm_platform_get_and_ioremap_resource(pdev, 0, &res);

..., 1, ...

>         if (IS_ERR(ipctl->lev2))
>                 return PTR_ERR(ipctl->lev2);
> +       ipctl->lev2_protect_phys = (u32)res->start + 0x400;
>
>         ipctl->clk = devm_clk_get(&pdev->dev, NULL);
>         if (IS_ERR(ipctl->clk))

Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
i.e. will queue in renesas-pinctrl-for-v5.19, with the above fixed
(no need to resend).

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds