linux-kernel - Re: [PATCH] firmware_loader: describe 'module' parameter of firmware_upload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a6906b8-6ff4-c44c-000d-5f7110d19df5@intel.com>
Date:   Mon, 2 May 2022 09:28:51 -0700
From:   Russ Weight <russell.h.weight@...el.com>
To:     Bagas Sanjaya <bagasdotme@...il.com>, <linux-doc@...r.kernel.org>
CC:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Luis Chamberlain <mcgrof@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: [PATCH] firmware_loader: describe 'module' parameter of
 firmware_upload_register()



On 5/1/22 22:14, Bagas Sanjaya wrote:
> Stephen Rothwell reported kernel-doc warning:
>
> drivers/base/firmware_loader/sysfs_upload.c:285: warning: Function parameter or member 'module' not described in 'firmware_upload_register'
>
> Fix the warning by describing the 'module' parameter.
>
> Fixes: 97730bbb242cde ("firmware_loader: Add firmware-upload support")
> Link: https://lore.kernel.org/linux-next/20220502083658.266d55f8@canb.auug.org.au/
> Cc: Stephen Rothwell <sfr@...b.auug.org.au>
> Cc: Russ Weight <russell.h.weight@...el.com>
> Cc: Luis Chamberlain <mcgrof@...nel.org>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: "Rafael J. Wysocki" <rafael@...nel.org>
> Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
> Cc: Linux Next Mailing List <linux-next@...r.kernel.org>

Reviewed-by: Russ Weight <russell.h.weight@...el.com>

> Signed-off-by: Bagas Sanjaya <bagasdotme@...il.com>
> ---
>  This patch is based on driver-core-next tree.
>
>  drivers/base/firmware_loader/sysfs_upload.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/base/firmware_loader/sysfs_upload.c b/drivers/base/firmware_loader/sysfs_upload.c
> index 8cdcf3516c7e94..87044d52322aa2 100644
> --- a/drivers/base/firmware_loader/sysfs_upload.c
> +++ b/drivers/base/firmware_loader/sysfs_upload.c
> @@ -266,6 +266,7 @@ int fw_upload_start(struct fw_sysfs *fw_sysfs)
>  
>  /**
>   * firmware_upload_register() - register for the firmware upload sysfs API
> + * @module: kernel module of this device
>   * @parent: parent device instantiating firmware upload
>   * @name: firmware name to be associated with this device
>   * @ops: pointer to structure of firmware upload ops
>
> base-commit: f8ae07f4b8bfde0f33761e1a1aaee45a4e85e9d6