lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 2 May 2022 18:57:04 +0200 From: Javier Martinez Canillas <javierm@...hat.com> To: Laurent Pinchart <laurent.pinchart@...asonboard.com> Cc: linux-kernel@...r.kernel.org, Thomas Zimmermann <tzimmermann@...e.de>, Daniel Vetter <daniel.vetter@...ll.ch>, amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org, linux-amlogic@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org, linux-mediatek@...ts.infradead.org, linux-mips@...r.kernel.org, linux-renesas-soc@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com, linux-sunxi@...ts.linux.dev, spice-devel@...ts.freedesktop.org, virtualization@...ts.linux-foundation.org Subject: Re: [PATCH v2 2/3] drm/fb-helper: Rename preferred_bpp drm_fbdev_generic_setup() parameter On 5/2/22 18:07, Laurent Pinchart wrote: > Hi Javier, > > Thank you for the patch. > > On Mon, May 02, 2022 at 05:38:59PM +0200, Javier Martinez Canillas wrote: >> By default the bits per pixel for the emulated framebuffer device is set >> to dev->mode_config.preferred_depth, but some devices need another value. >> >> Since this second parameter is only used by a few drivers, and to allow >> drivers to use it for passing other configurations when registering the >> fbdev, rename @preferred_bpp to @options and make it a multi-field param. >> >> The DRM_FB_OPTION() and DRM_FB_GET_OPTION() macros are provided to drivers >> for computing options bitfield values and getting the values respectively >> >> For now, only the DRM_FB_BPP option exists but other options can be added. >> >> Suggested-by: Thomas Zimmermann <tzimmermann@...e.de> >> Signed-off-by: Javier Martinez Canillas <javierm@...hat.com> >> Reviewed-by: Thomas Zimmermann <tzimmermann@...e.de> >> Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com> >> --- >> >> Changes in v2: >> - Rename DRM_FB_SET_OPTION() to DRM_FB_SET() and make more clear in the > > I assume you meant DRM_FB_OPTION() here, not DRM_FB_SET(). > >> kernel-doc what this macro does (Laurent Pinchart). >> Right, that's a typo. The patch description and content are correct though. I'll fix the patch history log in v3. -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat
Powered by blists - more mailing lists