linux-kernel - Re: clang-format inconsistencies with checkpatch.pl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ee3feb13-fbf8-6651-76ff-1324878d72e8@digikod.net>
Date:   Mon, 2 May 2022 21:13:05 +0200
From:   Mickaël Salaün <mic@...ikod.net>
To:     Miguel Ojeda <ojeda@...nel.org>,
        Andy Whitcroft <apw@...onical.com>,
        Joe Perches <joe@...ches.com>,
        Dwaipayan Ray <dwaipayanray1@...il.com>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>
Cc:     Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Tom Rix <trix@...hat.com>, llvm@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: clang-format inconsistencies with checkpatch.pl


On 23/04/2022 13:45, Mickaël Salaün wrote:
> Hi,
> 
> I would like to use clang-format (with a pinned version, probably 14) to 
> keep a consistent coding style, or at least start with one. However, 
> there is some inconsistencies with the checkpatch.pl script:
> 
> In some cases, goto labels are indented, which checkpatch.pl doesn't like.

This can be fixed with SplitEmptyFunction: false. I'll send a patch for 
that if it's OK with you.

> 
> checkpatch.pl complains about some functions (e.g. FIXTURE or 
> FIXTURE_VARIANT_ADD) that get an open brace just after but without a space.

Miguel, do you know how/if clang-format can enforce that style? FIXTURE 
macros are struct declarations though.