linux-kernel - Re: [PATCH v2 1/2] dt-bindings: watchdog: max63xx: Add GPIO binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 4 May 2022 00:02:02 +0200
From:   Pali Rohár <pali@...nel.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Guenter Roeck <linux@...ck-us.net>,
        linux-watchdog@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: watchdog: max63xx: Add GPIO binding

On Tuesday 03 May 2022 16:51:37 Rob Herring wrote:
> On Fri, Apr 29, 2022 at 03:13:48PM +0200, Pali Rohár wrote:
> > GPIO is optional and used for WDI logic.
> 
> Nowhere is WDI defined.
> 
> > 
> > Signed-off-by: Pali Rohár <pali@...nel.org>
> > ---
> >  Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml b/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml
> > index ab9641e845db..a97aa0135ef9 100644
> > --- a/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml
> > +++ b/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml
> > @@ -27,6 +27,10 @@ properties:
> >      description: This is a 1-byte memory-mapped address
> >      maxItems: 1
> >  
> > +  gpios:
> 
> Usually, we want a name here. Maybe wdi-gpios, but I don't know what WDI 
> is nor have I read the pin name in the datasheet for inspiration.

WDI is name of logic used in the datasheet, it is abbreviation of
WatchDog Input (meaning that from watchdog chip this GPIO has input
direction).

I'm not sure if we need to put gpio direction into the property name or
also word watchdog (or its some abbrev) into name. As node is already
named "watchdog" and direction depends on point of view (chip vs CPU),
which can be in DTS misleading (because DTS describe direction from CPU
point of view).

What for sure makes sense is extending description by explaining WDI
abbreviation.

> > +    description: Optional GPIO used for controlling WDI when WDI bit is not mapped to memory
> > +    maxItems: 1
> > +
> >  required:
> >    - compatible
> >    - reg
> > -- 
> > 2.20.1
> > 
> >