[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YnDmbUCDf7SVPo0s@atomide.com>
Date: Tue, 3 May 2022 11:23:09 +0300
From: Tony Lindgren <tony@...mide.com>
To: Arnd Bergmann <arnd@...db.de>
Cc: kernel test robot <lkp@...el.com>, kbuild-all@...ts.01.org,
Linux Memory Management List <linux-mm@...ck.org>,
Russell King <linux@...linux.org.uk>,
linux-omap <linux-omap@...r.kernel.org>,
Linux ARM <linux-arm-kernel@...ts.infradead.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: dove: fix returnvar.cocci warnings
* Arnd Bergmann <arnd@...db.de> [220503 08:12]:
> On Tue, May 3, 2022 at 9:30 AM Tony Lindgren <tony@...mide.com> wrote:
> > * Arnd Bergmann <arnd@...db.de> [220503 07:18]:
> > > On Tue, May 3, 2022 at 4:45 AM kernel test robot <lkp@...el.com> wrote:
> > > >
> > > > From: kernel test robot <lkp@...el.com>
> > > >
> > > > arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return "0" on line 161
> > > >
> > > >
> > > > Remove unneeded variable used to store return value.
> > > >
> > > > Generated by: scripts/coccinelle/misc/returnvar.cocci
> > > >
> > > > Reported-by: kernel test robot <lkp@...el.com>
> > > > Signed-off-by: kernel test robot <lkp@...el.com>
> > >
> > > I checked the patch, and unfortunately it is wrong, the current code
> > > needs to stay.
> > > The problem is the SET_DMA_ERRATA() macro that accesses the
> > > local 'errata' variable.
> >
> > Yeah this one keeps popping up. Maybe we can make SET_DMA_ERRATA
> > into a function or have it at least change it to set the errata
> > value.
>
> I would just remove the macro and open-code the assignment, which
> I think makes it more readable to both people and tools.
Yeah agree after looking at the macro :)
Regards,
Tony
Powered by blists - more mailing lists