linux-kernel - Re: [PATCH 1/7] serial: pch: move size check from pop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VfLw2pYMvaEoF+JuqN+H0wyo7ZfbkpefwtebCkOGVT0QQ@mail.gmail.com>
Date:   Tue, 3 May 2022 11:24:53 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Jiri Slaby <jslaby@...e.cz>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/7] serial: pch: move size check from pop_tx one level up

On Tue, May 3, 2022 at 10:12 AM Jiri Slaby <jslaby@...e.cz> wrote:
>
> 'count' is zero in the pop_tx()'s comparison against 'size'. So the 'if'
> tries to find out if 'size' is negative or zero and returns in that
> case. But it cannot be negative, due to previous (size < 0) check in the
> caller: handle_tx().
>
> So simply move this check from pop_tx() to handle_tx(). Now it's clear
> that pop_tx() is called only if fifo_size is non-zero.

I'm in favour of the series, but ideally this driver should be
converted to be a part of the 8250 family.

-- 
With Best Regards,
Andy Shevchenko