[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <528f8b2528d694dd4742c2b0b439bb30474c911c.camel@mediatek.com>
Date: Tue, 3 May 2022 17:48:47 +0800
From: Rex-BC Chen <rex-bc.chen@...iatek.com>
To: Rob Herring <robh@...nel.org>
CC: <matthias.bgg@...il.com>, <linux-arm-kernel@...ts.infradead.org>,
<chunkuang.hu@...nel.org>, <jitao.shi@...iatek.com>,
<linux-kernel@...r.kernel.org>, <airlied@...ux.ie>,
<krzysztof.kozlowski+dt@...aro.org>, <daniel@...ll.ch>,
<xinlei.lee@...iatek.com>, <devicetree@...r.kernel.org>,
<p.zabel@...gutronix.de>, <linux-mediatek@...ts.infradead.org>,
<dri-devel@...ts.freedesktop.org>, <cellopoint.kai@...il.com>
Subject: Re: [PATCH v5 1/4] dt-bindings: display: mediatek: dsi: Convert
dsi_dtbinding to .yaml
On Fri, 2022-04-29 at 15:06 -0500, Rob Herring wrote:
> On Fri, Apr 29, 2022 at 09:55:37AM +0800, Rex-BC Chen wrote:
> > On Thu, 2022-04-28 at 15:33 -0500, Rob Herring wrote:
> > > On Thu, 28 Apr 2022 21:37:50 +0800, Rex-BC Chen wrote:
> > > > From: Xinlei Lee <xinlei.lee@...iatek.com>
> > > >
> > > > Convert mediatek,dsi.txt to mediatek,dsi.yaml format
> > > >
> > > > Signed-off-by: Xinlei Lee <xinlei.lee@...iatek.com>
> > > > Signed-off-by: Rex-BC Chen <rex-bc.chen@...iatek.com>
> > > > ---
> > > > .../display/mediatek/mediatek,dsi.txt | 62 ---------
> > > > .../display/mediatek/mediatek,dsi.yaml | 122
> > > > ++++++++++++++++++
> > > > 2 files changed, 122 insertions(+), 62 deletions(-)
> > > > delete mode 100644
> > > > Documentation/devicetree/bindings/display/mediatek/mediatek,dsi
> > > > .txt
> > > > create mode 100644
> > > > Documentation/devicetree/bindings/display/mediatek/mediatek,dsi
> > > > .yam
> > > > l
> > > >
> > >
> > > Running 'make dtbs_check' with the schema in this patch gives the
> > > following warnings. Consider if they are expected or the schema
> > > is
> > > incorrect. These may not be new warnings.
> > >
> > > Note that it is not yet a requirement to have 0 warnings for
> > > dtbs_check.
> > > This will change in the future.
> > >
> > > Full log is available here:
> > >
https://urldefense.com/v3/__https://patchwork.ozlabs.org/patch/__;!!CTRNKA9wMg0ARbw!wKbRsUmeUS_4mtOwj1t30buVNEilHYYhsUmEd5MvZ7P9VyDXg6cikERof47mkwETQzFL$
> > >
> > >
> > >
> > > dsi@...0c000: compatible: ['mediatek,mt7623-dsi',
> > > 'mediatek,mt2701-
> > > dsi'] is too long
> > > arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dtb
> > > arch/arm/boot/dts/mt7623n-rfb-emmc.dtb
> > >
> > > dsi@...14000: #address-cells:0:0: 2 was expected
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14-
> > > sku2.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-
> > > sku1.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-
> > > sku6.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-
> > > sku7.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper-
> > > sku16.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kappa.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kenzo.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow-
> > > sku0.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow-
> > > sku1.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu-sku22.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku16.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku272.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku288.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku32.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dtb
> > >
> > > dsi@...14000: 'port' is a required property
> > > arch/arm64/boot/dts/mediatek/mt8183-evb.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14-
> > > sku2.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-
> > > sku1.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-
> > > sku6.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-
> > > sku7.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper-
> > > sku16.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kappa.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kenzo.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow-
> > > sku0.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow-
> > > sku1.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu-sku22.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku16.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku272.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku288.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku32.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dtb
> > >
> > > dsi@...14000: #size-cells:0:0: 2 was expected
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14-
> > > sku2.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-
> > > sku1.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-
> > > sku6.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-
> > > sku7.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper-
> > > sku16.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kappa.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kenzo.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow-
> > > sku0.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow-
> > > sku1.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu-sku22.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku16.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku272.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku288.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku32.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dtb
> > > arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dtb
> > >
> > > dsi@...1b000: 'port' is a required property
> > > arch/arm64/boot/dts/mediatek/mt8173-elm.dtb
> > > arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtb
> > > arch/arm64/boot/dts/mediatek/mt8173-elm-hana-rev7.dtb
> > >
> >
> > Hello Rob,
> >
> > Thanks for your comments.
> > The purpose of this series is not to fix dts for previous SoCs.
> > Therefore, if there is a chance, we could send another series to
> > fix
> > them.
>
> Conversions often find that the actual dts files vary a bit more
> than
> the binding doc said. You should look at the warnings and decide if
> they
> should be fixed or the schema relaxed. It's a judgement call. I have
> no
> idea if you did that already or not, so I send this out on
> conversions.
> The check runs automatically, but sending it I review briefly.
>
> Rob
Hello Rob,
Thanks for your explanation!
In addition, do you have any suggestion for this conversion?
BRs,
Rex
Powered by blists - more mailing lists